Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete unnecessary settings #29

Merged
merged 1 commit into from
Apr 10, 2018
Merged

Conversation

YujiOshima
Copy link
Contributor

There are some unnecessary setting in manifests.

Signed-off-by: YujiOshima yuji.oshima0x3fd@gmail.com

Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>
@k8s-ci-robot
Copy link

@YujiOshima: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
kubeflow-hp-tuning-presubmit c64feaf link /test kubeflow-hp-tuning-presubmit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@YujiOshima
Copy link
Contributor Author

/assign @gaocegege

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gaocegege gaocegege merged commit a1f30d4 into kubeflow:master Apr 10, 2018
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants