Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kserve: Use correct configuration for showing model-web-apps from kserve on central dashboard #362

Merged
merged 2 commits into from
Mar 30, 2022

Conversation

zijianjoy
Copy link
Collaborator

@zijianjoy zijianjoy commented Mar 30, 2022

Fix kubeflow/manifests#2180

  1. Central dashboard should have used the upstream/overlays/kserve.
  2. Provide an option to switch to kfserving overlay on central dashboard.
  3. Remove a previous patch which is conflicting with virtual service prefix set by kserve.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zijianjoy zijianjoy added the lgtm label Mar 30, 2022
@google-oss-prow google-oss-prow bot merged commit bef1ac8 into GoogleCloudPlatform:master Mar 30, 2022
gkcalat pushed a commit that referenced this pull request Jul 8, 2022
…rve on central dashboard (#362)

* kserve: Use correct configuration for showing model-web-apps from kserve on central dashboard

* indent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KServe Model Web App is pulling asset from a wrong endpoint
1 participant