Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions to deploy the seldon core model #46

Merged
merged 2 commits into from
Mar 15, 2018
Merged

Add instructions to deploy the seldon core model #46

merged 2 commits into from
Mar 15, 2018

Conversation

ankushagarwal
Copy link

@ankushagarwal ankushagarwal commented Mar 14, 2018

Update the issue summarization end to end tutorial
to deploy the seldon core model to the k8s cluster

Update the sample request and response

Related to #11


This change is Reviewable

Update the issue summarization end to end tutorial
to deploy the seldon core model to the k8s cluster

Update the sample request and response

Related to #11
@ankushagarwal
Copy link
Author

/uncc @wbuchwalter
/uncc @DjangoPeng
/cc @cliveseldon
/cc @texasmichelle

@k8s-ci-robot k8s-ci-robot requested review from ukclivecox and texasmichelle and removed request for wbuchwalter and DjangoPeng March 14, 2018 02:19
@texasmichelle
Copy link
Member

Looks good at first glance. Running through the additional steps to verify.

@texasmichelle
Copy link
Member

/lgtm
/approve

@ankushagarwal
Copy link
Author

/approve

@k8s-ci-robot k8s-ci-robot removed the lgtm label Mar 15, 2018
@ankushagarwal
Copy link
Author

@texasmichelle Can you LGTM again?

@texasmichelle
Copy link
Member

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankushagarwal, texasmichelle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 45255b5 into kubeflow:master Mar 15, 2018
@ankushagarwal ankushagarwal deleted the serving_seldon_container branch March 15, 2018 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants