Add opcua mapper #4
Conversation
kubeedge-bot
added
the
size/XXL
|
@fisherxu @luogangyi |
|
|
||
| COPY ./opcua kubeedge/ | ||
| COPY ./config.yaml kubeedge/ | ||
| COPY ./ca /ca |
There was a problem hiding this comment.
It could be better if provide a tool to generate certs.
There was a problem hiding this comment.
Thanks for your comment. The cert is a demo. It depends on the external opcua server.
There was a problem hiding this comment.
I think we should provide a tool to generate them although it is a demo.
There was a problem hiding this comment.
We can remove it from dockerfile/image, and mount into contaier if needed
There was a problem hiding this comment.
The customer could package it without any file or with the files for them own. It depends on the authentication method the opcua server requires. This folder is an example that the customer could refer to.
Makefile
Outdated
| sudo docker build -t opcuamapper:v1.0 ./pkg/opcua | ||
|
|
||
| clean: | ||
| rm -f ./pkg/modbus/modbus ./pkg/opcua/modbus |
There was a problem hiding this comment.
| rm -f ./pkg/modbus/modbus ./pkg/opcua/modbus | |
| rm -f ./pkg/modbus/modbus ./pkg/opcua/opcua |
?
|
|
||
| COPY ./opcua kubeedge/ | ||
| COPY ./config.yaml kubeedge/ | ||
| COPY ./ca /ca |
There was a problem hiding this comment.
We can remove it from dockerfile/image, and mount into contaier if needed
| @@ -0,0 +1 @@ | |||
| testpass | |||
There was a problem hiding this comment.
It's the password file. The original design is that: define the username & password in the device instance yaml and pass it by the configmap. I think it's dangerous and change to use the password file which is in local directory.
pkg/opcua/driver/client_test.go
Outdated
| Certfile: "/home/wei/ca/clientcert.pem", | ||
| Keyfile: "/home/wei/ca/clientkey.pem", | ||
| RemoteCertfile: "/home/wei/ca/servercert.pem", | ||
| */ |
There was a problem hiding this comment.
We can remove it if unnecessary
There was a problem hiding this comment.
Sorry, I'll refine the test. There're several test cases in one test function.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fisherxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubeedge-bot
added
the
approved
|
@sailorvii Let's fix any issues in follow-up PRs. |
The issue is at kubeedge/kubeedge#2461.
This mapper uses open source code github.com/gopcua/opcua as the driver.
The code framework refers to the modbus mapper.
It has been tested with simulated opcua server & device: https://python-opcua.readthedocs.io/en/latest/.