Skip to content

Commit

Permalink
update review changes
Browse files Browse the repository at this point in the history
Signed-off-by: Mehedi Hasan <mehedi.hasan@appscode.com>
  • Loading branch information
heheh13 committed Dec 12, 2022
1 parent e1f4fbd commit a209cd7
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 93 deletions.
96 changes: 4 additions & 92 deletions docs/guides/mysql/autoscaler/compute/cluster/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -207,56 +207,7 @@ Metadata:
Creation Timestamp: 2022-09-16T11:26:58Z
Generation: 1
Managed Fields:
API Version: autoscaling.kubedb.com/v1alpha1
Fields Type: FieldsV1
fieldsV1:
f:metadata:
f:annotations:
.:
f:kubectl.kubernetes.io/last-applied-configuration:
f:spec:
.:
f:compute:
.:
f:mysql:
.:
f:containerControlledValues:
f:controlledResources:
f:maxAllowed:
.:
f:cpu:
f:memory:
f:minAllowed:
.:
f:cpu:
f:memory:
f:podLifeTimeThreshold:
f:resourceDiffPercentage:
f:trigger:
f:databaseRef:
.:
f:name:
f:opsRequestOptions:
.:
f:apply:
f:timeout:
Manager: kubectl-client-side-apply
Operation: Update
Time: 2022-09-16T11:26:58Z
API Version: autoscaling.kubedb.com/v1alpha1
Fields Type: FieldsV1
fieldsV1:
f:status:
.:
f:checkpoints:
f:conditions:
f:vpas:
Manager: kubedb-autoscaler
Operation: Update
Subresource: status
Time: 2022-09-16T11:27:07Z
Resource Version: 846645
UID: 44bd46c3-bbc5-4c4a-aff4-00c7f84c6f58
...
Spec:
Compute:
MySQL:
Expand Down Expand Up @@ -387,48 +338,7 @@ Metadata:
Creation Timestamp: 2022-09-16T11:27:07Z
Generation: 1
Managed Fields:
API Version: ops.kubedb.com/v1alpha1
Fields Type: FieldsV1
fieldsV1:
f:metadata:
f:ownerReferences:
.:
k:{"uid":"44bd46c3-bbc5-4c4a-aff4-00c7f84c6f58"}:
f:spec:
.:
f:apply:
f:databaseRef:
.:
f:name:
f:timeout:
f:type:
f:verticalScaling:
.:
f:mysql:
.:
f:limits:
.:
f:cpu:
f:memory:
f:requests:
.:
f:cpu:
f:memory:
Manager: kubedb-autoscaler
Operation: Update
Time: 2022-09-16T11:27:07Z
API Version: ops.kubedb.com/v1alpha1
Fields Type: FieldsV1
fieldsV1:
f:status:
.:
f:conditions:
f:observedGeneration:
f:phase:
Manager: kubedb-ops-manager
Operation: Update
Subresource: status
Time: 2022-09-16T11:27:07Z
...
Owner References:
API Version: autoscaling.kubedb.com/v1alpha1
Block Owner Deletion: true
Expand Down Expand Up @@ -534,5 +444,7 @@ To clean up the Kubernetes resources created by this tutorial, run:
```bash
kubectl delete mysql -n demo sample-mysql
kubectl delete mysqlautoscaler -n demo my-as-compute
kubectl delete mysqlopsrequest -n demo myops-vpa-sample-mysql-z43wc8
kubectl delete mysqlopsrequest -n demo myops-sample-mysql-6xc1kc
kubectl delete ns demo
```
2 changes: 1 addition & 1 deletion docs/guides/mysql/clustering/read-replica/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ mysql.kubedb.com/mysql created
```
Here,

- `spec.AllowReadReplicas` defines the types of read replicas that MAY be attached to a MySQL instance and the trusted namespaces where those Read Replica resources MAY be present.You will be able to set namespace `spec.allowReadReplicas.NameSpace` and labels `spec.allowReadReplicas.selector`.For more see [here](https://github.com/kubedb/apimachinery/blob/master/apis/kubedb/v1alpha2/mysql_types.go#L159).
- `spec.AllowReadReplicas` defines the types of read replicas that may be attached to a MySQL instance and the trusted namespaces where those Read Replica resources may be present.You will be able to set namespace `spec.allowReadReplicas.NameSpace` and labels `spec.allowReadReplicas.selector`.For more see [here](https://github.com/kubedb/apimachinery/blob/master/apis/kubedb/v1alpha2/mysql_types.go#L159).
- `spec.terminationPolicy` specifies what KubeDB should do when a user try to delete the operation of MySQL CR. *Wipeout* means that the database will be deleted without restrictions. It can also be "Halt", "Delete" and "DoNotTerminate". Learn More about these [HERE](https://kubedb.com/docs/latest/guides/mysql/concepts/database/#specterminationpolicy).

Now a MySQL instance in `demo` namespace having the label `kubedb.com/instance_name: ReadReplica` will be able to connect to this database as a read replica
Expand Down

0 comments on commit a209cd7

Please sign in to comment.