Sync api to another repo #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ErikJiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubean-pr-robot
bot
added
the
approved
|
/lgtm |
Michelle951
reviewed
Sep 9, 2022
hack/sync_api.sh
Outdated
|
|
||
| # git clone. | ||
|
|
||
| # This function installs a Go tools by 'go get' command. |
There was a problem hiding this comment.
Suggested change
| # This function installs a Go tools by 'go get' command. | |
| # This function installs a Go tool by 'go get' command. |
hack/sync_api.sh
Outdated
| set -o pipefail | ||
| # set -o xtrace | ||
|
|
||
| # This script will sync kubean api declaration to single repo. |
There was a problem hiding this comment.
Suggested change
| # This script will sync kubean api declaration to single repo. | |
| # This script will sync kubean api declaration to a single repo. |
Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
|
/lgtm |
|
/lgtm |
|
/lgtm |
|
/woof |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: bo.jiang bo.jiang@daocloud.io
What type of PR is this?
/kind feature
What this PR does / why we need it:
Expose kubean's API through a single repository.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: