Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a lockfile #1337

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add a lockfile #1337

wants to merge 2 commits into from

Commits on Nov 8, 2023

  1. Add a lockfile 

    From a blank build today.

Reasons;

- basically https://blog.rust-lang.org/2023/08/29/committing-lockfiles.html
- frequently we get cargo deny issues pulled in from under us which we have to explain away
- contributor confusion; why does this not build? we don't want them to be the first to notice a breaking build, that's CIs job
- we can setup dependabot to auto-merge non-breaking changes that pass CI

Downsides:

- we still have to manually fix up most cargo deny issues
- we might get a lot more PRs, but if most are auto-merged that's ok

AFAIU non-breaking builds do not need to get pins updated from `Cargo.toml` so this should mostly be a sanity thing for CI and contributors (rather than forcing everyone to bump the dependencies of us).

Signed-off-by: clux <sszynrae@gmail.com>
    @clux
    clux committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    37c78fe View commit details
    Browse the repository at this point in the history

  2. add auto-merge for patch changes 

    Signed-off-by: clux <sszynrae@gmail.com>
    @clux
    clux committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    01dec7f View commit details
    Browse the repository at this point in the history