Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update envtest version to support darwin/arm64 #1131

Merged
merged 2 commits into from
Nov 16, 2022
Merged

update envtest version to support darwin/arm64 #1131

merged 2 commits into from
Nov 16, 2022

Conversation

bshifter
Copy link
Contributor

@bshifter bshifter commented Nov 10, 2022 •
edited by siliconbrain
Loading

Q A
Bug fix? yes
New feature? no
API breaks? no
Deprecations? no
License Apache 2.0

What's in this PR?

Tests weren't able to create darwin/arm64 envtest on new M1 MacBooks.

Checklist

  • Code meets the Developer Guide
  • User guide and development docs updated (if needed)
  • Related Helm chart(s) updated (if needed)

ahma
ahma approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@ahma ahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! lgtm

@ahma ahma merged commit 4329dab into master Nov 16, 2022
@ahma ahma deleted the darwin-arm64-test-update branch November 16, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahma ahma ahma approved these changes

@siliconbrain siliconbrain siliconbrain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bshifter @siliconbrain @ahma