Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tailer-webhook non-uniq containername fix #1107

Merged
merged 3 commits into from
Oct 1, 2022

Conversation

bshifter
Copy link
Contributor

tailer-webhook now generates sidecar names with original containernam…e included to avoid container name collisions

Q A
Bug fix? yes
New feature? no
API breaks? no
Deprecations? no
License Apache 2.0

What's in this PR?

Tailer-webhook generates sidecar container names from tailed file name. Operator was unable to initiate sidecar container due to unique name issue if there were multiple files to tail with the same name on different containers.

Checklist

  • Code meets the Developer Guide
  • User guide and development docs updated (if needed)
  • Related Helm chart(s) updated (if needed)

…e included to avoid container name collisions
Copy link
Contributor

@siliconbrain siliconbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@ahma ahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@ahma ahma merged commit 2ec9dfb into master Oct 1, 2022
@ahma ahma deleted the tailer-webhook-uniq-container-names branch October 1, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants