feat: delete Fluentd PVC on drain success #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslafy-z
force-pushed
the
feat/delete-drained-pvc
branch
5 times, most recently
from
b0125a3 to
44e01d6
Compare
aslafy-z
changed the title
aslafy-z
changed the title
aslafy-z
force-pushed
the
feat/delete-drained-pvc
branch
from
44e01d6 to
5cc1f85
Compare
aslafy-z
force-pushed
the
feat/delete-drained-pvc
branch
3 times, most recently
from
74049b5 to
993a43b
Compare
aslafy-z
force-pushed
the
feat/delete-drained-pvc
branch
from
993a43b to
0d1a173
Compare
aslafy-z
force-pushed
the
feat/delete-drained-pvc
branch
from
0d1a173 to
07b359f
Compare
aslafy-z
force-pushed
the
feat/delete-drained-pvc
branch
from
07b359f to
ba39d89
Compare
siliconbrain
previously approved these changes
Sep 7, 2022
ahma
previously approved these changes
Sep 7, 2022
aslafy-z
force-pushed
the
feat/delete-drained-pvc
branch
from
ba39d89 to
103eb06
Compare
Signed-off-by: GitHub <noreply@github.com>
aslafy-z
force-pushed
the
feat/delete-drained-pvc
branch
from
103eb06 to
2ec4d4a
Compare
siliconbrain
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
In the fluentd drainer reconciliation loop, remove the PVC once the drainer job finished successfully.
Checklist