Move namespaced to the internal structure #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ygalblum
force-pushed
the
namespaced-internal
branch
2 times, most recently
from
9af9791 to
664f132
Compare
|
Can you rebase please? |
Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
ygalblum
force-pushed
the
namespaced-internal
branch
from
664f132 to
e767676
Compare
Done |
rsevilla87
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
The field
Namespacedof the externalObjectis never passed by the user and always gets set internally. Therefore, the field belongs to the internalobjectstructure and can be renamed tonamespaced