Do not use mocks (#934)

kubawerlos · Dec 23, 2023 · 1adfc79 · 1adfc79
1 parent 4a8ff9d
commit 1adfc79
Show file tree

Hide file tree

Showing 6 changed files with 69 additions and 14 deletions.
diff --git a/.dev-tools/phpcs.xml b/.dev-tools/phpcs.xml
@@ -15,6 +15,7 @@
         <exclude name='Generic.Files.LineLength' />
         <exclude name='PSR12.Files.FileHeader.SpacingAfterBlock' />
         <exclude name='PSR12.Files.OpenTag.NotAlone' />
+        <exclude name='Squiz.WhiteSpace.ScopeClosingBrace.ContentBefore' />
     </rule>
 
 </ruleset>
diff --git a/tests/AutoReview/SrcCodeTest.php b/tests/AutoReview/SrcCodeTest.php
@@ -13,6 +13,7 @@
 
 use PhpCsFixer\Fixer\DeprecatedFixerInterface;
 use PhpCsFixer\Fixer\FixerInterface;
+use PhpCsFixer\FixerDefinition\FixerDefinitionInterface;
 use PhpCsFixer\FixerNameValidator;
 use PhpCsFixer\Tokenizer\Token;
 use PhpCsFixer\Tokenizer\Tokens;
@@ -82,9 +83,7 @@ public static function provideFixerCases(): iterable
 
     public function testFixerSupportsAllFilesByDefault(): void
     {
-        $fixer = $this->getMockForAbstractClass(AbstractFixer::class);
-
-        self::assertTrue($fixer->supports($this->createMock(\SplFileInfo::class)));
+        self::assertTrue($this->createAbstractFixerDouble()->supports($this->createSplFileInfoDouble()));
     }
 
     /**
@@ -148,4 +147,39 @@ public static function provideThereIsNoPregFunctionUsedDirectlyCases(): iterable
             yield $className => [$className];
         }
     }
+
+    private function createAbstractFixerDouble(): AbstractFixer
+    {
+        return new class () extends AbstractFixer {
+            public function isCandidate(Tokens $tokens): bool
+            {
+                throw new \BadMethodCallException('Not implemented.');
+            }
+
+            public function isRisky(): bool
+            {
+                throw new \BadMethodCallException('Not implemented.');
+            }
+
+            public function fix(\SplFileInfo $file, Tokens $tokens): void
+            {
+                throw new \BadMethodCallException('Not implemented.');
+            }
+
+            public function getDefinition(): FixerDefinitionInterface
+            {
+                throw new \BadMethodCallException('Not implemented.');
+            }
+
+            public function getPriority(): int
+            {
+                throw new \BadMethodCallException('Not implemented.');
+            }
+        };
+    }
+
+    private function createSplFileInfoDouble(): \SplFileInfo
+    {
+        return new class ('') extends \SplFileInfo {};
+    }
 }
diff --git a/tests/Fixer/AbstractFixerTestCase.php b/tests/Fixer/AbstractFixerTestCase.php
@@ -107,7 +107,7 @@ final public function testCodeSampleIsChangedDuringFixing(): void
         Tokens::clearCache();
         $tokens = Tokens::fromCode($codeSample->getCode());
 
-        self::getFixer()->fix($this->createMock(\SplFileInfo::class), $tokens);
+        self::getFixer()->fix($this->createSplFileInfoDouble(), $tokens);
 
         self::assertNotSame($codeSample->getCode(), $tokens->generateCode());
     }
@@ -180,7 +180,7 @@ final protected function doTest(string $expected, ?string $input = null, ?array
 
             self::assertTrue($fixer->isCandidate($inputTokens));
 
-            $fixer->fix($this->createMock(\SplFileInfo::class), $inputTokens);
+            $fixer->fix($this->createSplFileInfoDouble(), $inputTokens);
             $inputTokens->clearEmptyTokens();
 
             self::assertSame(
@@ -196,7 +196,7 @@ final protected function doTest(string $expected, ?string $input = null, ?array
             self::assertSameTokens($expectedTokens, $inputTokens);
         }
 
-        $fixer->fix($this->createMock(\SplFileInfo::class), $expectedTokens);
+        $fixer->fix($this->createSplFileInfoDouble(), $expectedTokens);
 
         self::assertSame($expected, $expectedTokens->generateCode());
 
@@ -242,4 +242,9 @@ final protected function assertSuccessorName(string $successorName): void
         self::assertInstanceOf(DeprecatedFixerInterface::class, $fixer);
         self::assertSame([$successorName], $fixer->getSuccessorsNames());
     }
+
+    private function createSplFileInfoDouble(): \SplFileInfo
+    {
+        return new class ('') extends \SplFileInfo {};
+    }
 }
diff --git a/tests/Fixer/NumericLiteralSeparatorFixerTest.php b/tests/Fixer/NumericLiteralSeparatorFixerTest.php
@@ -49,7 +49,7 @@ public function testReversingCodeSample(): void
         Tokens::clearCache();
         $tokens = Tokens::fromCode($codeSample->getCode());
 
-        $fixer->fix($this->createMock(\SplFileInfo::class), $tokens);
+        $fixer->fix($this->createSplFileInfoDouble(), $tokens);
         self::assertNull($this->lintSource($tokens->generateCode()));
 
         $this->doTest(
@@ -192,4 +192,9 @@ public static function provideFixCases(): iterable
             ],
         ];
     }
+
+    private function createSplFileInfoDouble(): \SplFileInfo
+    {
+        return new class ('') extends \SplFileInfo {};
+    }
 }
diff --git a/tests/Fixer/SingleSpaceAfterStatementFixerTest.php b/tests/Fixer/SingleSpaceAfterStatementFixerTest.php
@@ -284,7 +284,7 @@ class    Foo {}
     public function testExampleWithAllTokensHasAllSpacesFixed(): void
     {
         $tokens = Tokens::fromCode(self::EXAMPLE_WITH_ALL_TOKENS);
-        self::getFixer()->fix($this->createMock(\SplFileInfo::class), $tokens);
+        self::getFixer()->fix($this->createSplFileInfoDouble(), $tokens);
 
         self::assertDoesNotMatchRegularExpression('/[^\n ] {2,}/', $tokens->generateCode());
     }
@@ -297,7 +297,7 @@ public function testTokenIsUseful(int $token): void
         $fixer = self::getFixer();
 
         $expectedTokens = Tokens::fromCode(self::EXAMPLE_WITH_ALL_TOKENS);
-        $fixer->fix($this->createMock(\SplFileInfo::class), $expectedTokens);
+        $fixer->fix($this->createSplFileInfoDouble(), $expectedTokens);
 
         $reflectionObject = new \ReflectionObject($fixer);
         $property = $reflectionObject->getProperty('tokens');
@@ -309,7 +309,7 @@ public function testTokenIsUseful(int $token): void
         $property->setValue($fixer, \array_diff($tokens, [$token]));
 
         $tokens = Tokens::fromCode(self::EXAMPLE_WITH_ALL_TOKENS);
-        $fixer->fix($this->createMock(\SplFileInfo::class), $tokens);
+        $fixer->fix($this->createSplFileInfoDouble(), $tokens);
 
         self::assertNotSame(
             $expectedTokens->generateCode(),
@@ -335,4 +335,9 @@ public static function provideTokenIsUsefulCases(): iterable
             yield [$token];
         }
     }
+
+    private function createSplFileInfoDouble(): \SplFileInfo
+    {
+        return new class ('') extends \SplFileInfo {};
+    }
 }
diff --git a/tests/PriorityTest.php b/tests/PriorityTest.php
@@ -48,10 +48,10 @@ public function testInOrder(FixerInterface $firstFixer, FixerInterface $secondFi
         Tokens::clearCache();
         $tokens = Tokens::fromCode($input);
 
-        $firstFixer->fix($this->createMock(\SplFileInfo::class), $tokens);
+        $firstFixer->fix($this->createSplFileInfoDouble(), $tokens);
         $tokens->clearEmptyTokens();
 
-        $secondFixer->fix($this->createMock(\SplFileInfo::class), $tokens);
+        $secondFixer->fix($this->createSplFileInfoDouble(), $tokens);
         $tokens->clearEmptyTokens();
 
         self::assertSame($expected, $tokens->generateCode());
@@ -68,10 +68,10 @@ public function testInRevertedOrder(FixerInterface $firstFixer, FixerInterface $
         Tokens::clearCache();
         $tokens = Tokens::fromCode($input);
 
-        $secondFixer->fix($this->createMock(\SplFileInfo::class), $tokens);
+        $secondFixer->fix($this->createSplFileInfoDouble(), $tokens);
         $tokens->clearEmptyTokens();
 
-        $firstFixer->fix($this->createMock(\SplFileInfo::class), $tokens);
+        $firstFixer->fix($this->createSplFileInfoDouble(), $tokens);
         $tokens->clearEmptyTokens();
 
         self::assertNotSame($expected, $tokens->generateCode());
@@ -130,4 +130,9 @@ private static function getFixer(string $name, array $config): FixerInterface
 
         throw new \Exception(\sprintf('Fixer "%s" not found in config: "%s".', $name, \json_encode($config)));
     }
+
+    private function createSplFileInfoDouble(): \SplFileInfo
+    {
+        return new class ('') extends \SplFileInfo {};
+    }
 }