Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHA256 hash of the TOS has changed #114

Open
thomastweets opened this issue Aug 1, 2016 · 15 comments
Open

SHA256 hash of the TOS has changed #114

thomastweets opened this issue Aug 1, 2016 · 15 comments

Comments

@thomastweets
Copy link

thomastweets commented Aug 1, 2016

With the update to the Let’s Encrypt Subscriber Agreement today (v.1.1.1) the SHA256 hash has changed to 6373439b9f29d67a5cd4d18cbc7f264809342dbf21cb2ba2fc7588df987a6221
I can create a pull request to change line 894/895 of simp_le.py, however, I am not sure whether this covers all of it (and I am not deep into the topic).

@LeoFidjeland
Copy link

Having this issue as well, cannot create any new certs at all.

Please approve the PR asap.

And thanks for all the great work :)

@andresmrm
Copy link

Also got same error here.

@LeoFidjeland : As an workaround you can pass parameter:
--tos_sha256 6373439b9f29d67a5cd4d18cbc7f264809342dbf21cb2ba2fc7588df987a6221.
At least here it worked.

@madshargreave
Copy link

+1, my app is down because I cannot renew my certificate. Any help is greatly appreciated

@amiryal
Copy link

amiryal commented Aug 2, 2016

To the best of my understanding, this issue only affects new registrations, and it can be worked around by using --tos_sha256 6373439..., as suggested by @andresmrm above. If using an existing (already registered) account key, then no changes are necessary. Correct?

@thomastweets
Copy link
Author

@amiryal True! However, some other software that makes use of simp_le does not allow to specify this parameter. (e.g. https://github.com/JrCs/docker-letsencrypt-nginx-proxy-companion or https://github.com/dokku/dokku-letsencrypt). I am working on a forked docker image of https://github.com/JrCs/docker-letsencrypt-nginx-proxy-companion to have a work-around for now as I indeed need to do new registrations with simp_le.

@thomastweets
Copy link
Author

@LeoFidjeland
Copy link

Awesome, thanks so much @thomastweets! Works perfectly!

You saved the day!!

fpletz added a commit to NixOS/nixpkgs that referenced this issue Aug 2, 2016
fpletz added a commit to NixOS/nixpkgs that referenced this issue Aug 9, 2016
Fixes #17455.

Also see kuba/simp_le#114.

(cherry picked from commit e55aa50)
karlmdavis added a commit to karlmdavis/justdavis-ansible that referenced this issue Aug 14, 2016
@vrozkovec
Copy link

Is this project still maintained?

@chicks-net
Copy link

@vrozkovec -- the author has been inactive on github since June. Maybe google has been keeping him busy.

kak-tus pushed a commit to kak-tus/letsencrypt-simp_le-auto that referenced this issue Sep 15, 2016
jb55 pushed a commit to jb55/nixpkgs that referenced this issue Sep 23, 2016
thom4parisot added a commit to thom4parisot/letsencrypt-alwaysdata that referenced this issue Oct 5, 2016
Rename command

Update TOS sha256 refs kuba/simp_le#114
@Thor77
Copy link

Thor77 commented Oct 22, 2016

Does anyone have contact to the maintainer?
If not, does anyone plan to create a organization for this project and start maintaining it again?

@chicks-net
Copy link

I gave up and I've migrated to acme.sh.

@wiz78
Copy link

wiz78 commented Dec 12, 2016

If you want to workaround the problem, you can comment a couple of lines in simp_le/venv/lib/python/site-packages/acme/messages.py:

        #if not set(canon_jobj).issubset(self._REGISTERED_TYPES): # <-- this line (should be 140)
            # TODO: acme-spec is not clear about this: 'It is a JSON
            # dictionary, whose keys are the "resource" values listed
            # in {{https-requests}}'z
         #   raise ValueError('Wrong directory fields') # <-- and this one

@amiryal
Copy link

amiryal commented Dec 12, 2016

@wiz78 the right way to do it is to upgrade the acme library to a later version, as implemented by this fork of simp_le. If you would like, you may suggest your change to ACME upstream.

@wiz78
Copy link

wiz78 commented Dec 12, 2016

@amiryal you're right. Mine was meant to be a dirty hack, since I was under the impression that the whole project had been abandoned.

@amiryal
Copy link

amiryal commented Dec 12, 2016

Glad to help inform people about the more maintained fork. :)

kak-tus pushed a commit to kak-tus/docker-letsencrypt-simp_le that referenced this issue Dec 18, 2016
kuba not maintains simpl_le about 6 months.
See kuba/simp_le#114.
So community forked simp_le to https://github.com/zenhack/simp_le.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants