Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.0.0] 회원 등록 api 추가 요청 대응 #204

Merged
merged 13 commits into from
Apr 30, 2024
Merged

[2.0.0] 회원 등록 api 추가 요청 대응 #204

merged 13 commits into from
Apr 30, 2024

Conversation

lgvv
Copy link
Member

@lgvv lgvv commented Apr 20, 2024 •
edited
Loading

내용

  • 유저 등록 api
  • 헤더에 User-Agent를 보내고 있어서 불필요한 api로 보입니다.

참고

  • 불필요한 api라고 판단되면 close할 예정입니다.
  • 배포일정이 빠듯한 관계로 리뷰 먼저 활성화하고 close 가능성이 있어서 Draft로 변경합니다.
    • 해당 서버 확인 결과 부분 반드시 필요

@x-0o0 @wonniiii

/cc
@mwy3055 @zbqmgldjfh

@lgvv lgvv changed the title Feature/lgvv/auth [2.0.0] 회원 등록 api 추가 요청 대응 Apr 20, 2024
@lgvv lgvv marked this pull request as draft April 20, 2024 07:35
@lgvv lgvv requested review from x-0o0, wonniiii and zbqmgldjfh and removed request for zbqmgldjfh April 20, 2024 07:35
@lgvv lgvv marked this pull request as ready for review April 20, 2024 12:41
mwy3055
mwy3055 reviewed Apr 20, 2024
View reviewed changes
Copy link
Member

@mwy3055 mwy3055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swift는 잘 모르지만, 코멘트 하나만 확인 부탁드려요

package-kuring/Sources/Networks/Depdencies/KuringLink.Dependency.swift Outdated Show resolved Hide resolved
@lgvv lgvv requested a review from mwy3055 April 20, 2024 12:51
@lgvv
Copy link
Member Author

lgvv commented Apr 20, 2024

/쿠링 빌드

mwy3055
mwy3055 previously approved these changes Apr 20, 2024
View reviewed changes
Copy link
Member

@mwy3055 mwy3055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

필드 이름 수정된 거 확인했습니다~

x-0o0
x-0o0 reviewed Apr 20, 2024
View reviewed changes
package-kuring/Sources/Models/AuthRequestQuery.swift Outdated
import Foundation

/// 계정 정보
public struct AuthRequest: Encodable {
Copy link
Contributor

@x-0o0 x-0o0 Apr 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

파일명과 타입명 불일치

@lgvv lgvv requested review from mwy3055 and x-0o0 April 20, 2024 15:05
x-0o0
x-0o0 reviewed Apr 28, 2024
View reviewed changes
Copy link
Contributor

@x-0o0 x-0o0 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저는 Approve 하면 안되기 때문에 커멘트만 남기겠습니다
✅ lgtm

@lgvv
Copy link
Member Author

lgvv commented Apr 28, 2024

저는 Approve 하면 안되기 때문에 커멘트만 남기겠습니다
lgtm

넵넵

@wonniiii

요거 확인 부탁드립니다. 이거까지 머지 후에 테플에 올려서 팀원 QA 진행 후 배포하면 좋을 것 같아요!

@x-0o0
Copy link
Contributor

x-0o0 commented Apr 28, 2024 •
edited
Loading

저는 Approve 하면 안되기 때문에 커멘트만 남기겠습니다
lgtm

넵넵

@wonniiii

요거 확인 부탁드립니다. 이거까지 머지 후에 테플에 올려서 팀원 QA 진행 후 배포하면 좋을 것 같아요!

배포 필요시 릴리즈 브랜치 따서 PR 저한테 주세요

@lgvv
Copy link
Member Author

lgvv commented Apr 28, 2024

저는 Approve 하면 안되기 때문에 커멘트만 남기겠습니다
lgtm

넵넵

@wonniiii

요거 확인 부탁드립니다. 이거까지 머지 후에 테플에 올려서 팀원 QA 진행 후 배포하면 좋을 것 같아요!

배포 필요시 릴리즈 브랜치 따서 PR 저한테 주세요

넵넵 + 카톡방에도 함께 공유드리겠습니다!

wonniiii
wonniiii approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@wonniiii wonniiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앗 시험이 어제 끝나서 이제 확인했습니다. 고생하셨습니다 !

@lgvv
Copy link
Member Author

lgvv commented Apr 30, 2024

/쿠링 머지

@github-actions github-actions bot added the automerge auto merge 를 수동으로 미리 활성화 하는 경우 라벨을 추가해줘야 합니다. "/쿠링 머지" 실행시 자동으로 추가. label Apr 30, 2024
@github-actions github-actions bot merged commit dc4e4e9 into develop/2.0.0 Apr 30, 2024
@github-actions github-actions bot deleted the feature/lgvv/auth branch April 30, 2024 11:51
@github-actions GitHub Actions
Copy link

🕊️ PR #204이 머지되었습니다.

@x-0o0 x-0o0 mentioned this pull request May 1, 2024
Merged
@ku-ring ku-ring deleted a comment from lgvv May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@x-0o0 x-0o0 x-0o0 left review comments

@wonniiii wonniiii wonniiii approved these changes

@mwy3055 mwy3055 Awaiting requested review from mwy3055

Assignees
No one assigned
Labels
automerge auto merge 를 수동으로 미리 활성화 하는 경우 라벨을 추가해줘야 합니다. "/쿠링 머지" 실행시 자동으로 추가.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lgvv @x-0o0 @mwy3055 @wonniiii