Snmpdetect fix cisco_ios detection and add routeros #3038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktbyers
requested changes
Nov 28, 2022
ktbyers
approved these changes
Nov 28, 2022
ktbyers
pushed a commit
that referenced
this pull request
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Team,
I've found some Cisco ios devices that were not matching the regexp due to the "," not being present
Example
Cisco IOS Software C881 Softwarewill not match".*Cisco IOS Software,.*"So I propose
".*Cisco IOS Software.*,.*"instead.I've run it successfully on many devices.
Additionally we can detect routeros via a very simple match.
Example of device output to snmprequest :
iso.3.6.1.2.1.1.1.0 = STRING: "RouterOS RB2011UiAS"Let me know what you think!
Kindly,