Allow changing the "readiness check" for different redis versions #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent redis versions
ikempf
force-pushed
the
future_proof_readiness
branch
from
e3e977f to
c8ab6a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different versions of Redis have different startup outputs. The currently implemented readiness check works for Redis 2.8.19 but not for Redis 4.0.4 nor 5.0.5.
Redis 5.0.5 standalone output
Redis 5.0.5 sentinel output
When defining a different redis executable (
RedisExecProvider) it should be possible to override the REDIS_READY_PATTEN