Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assay should default to counts in SummarizedExperiment objects #5

Open
2 of 3 tasks
drisso opened this issue May 16, 2020 · 1 comment
Open
2 of 3 tasks

Assay should default to counts in SummarizedExperiment objects #5

drisso opened this issue May 16, 2020 · 1 comment

Comments

@drisso
Copy link
Collaborator

drisso commented May 16, 2020 •
edited by willtownes
Loading

It seems to be the standard to store raw counts in the counts assay, so it would be a better default than the current (assay = 1).

  • Feature Selection
  • GLMPCA
  • Null residuals
@LTLA LTLA mentioned this issue Jun 1, 2020
Open
@willtownes
Copy link
Collaborator

willtownes commented Aug 26, 2020 •
edited
Loading

this is now implemented for feature selection. f130f73

@willtownes willtownes changed the title Suggetion: assay should default to counts in SummarizedExperiment objects Assay should default to counts in SummarizedExperiment objects Aug 26, 2020
willtownes added a commit that referenced this issue Aug 26, 2020
@willtownes
simplify GLMPCA method definitions and set default assay to 'counts' …
d1c8824 
…addresses #5 . Moves the L argument in front of assay since it is a required positional argument by glmpca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@willtownes @drisso