Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flat namespace on newer macOS #81

Closed
mrjbq7 opened this issue Jan 7, 2023 · 14 comments
Closed

Flat namespace on newer macOS #81

mrjbq7 opened this issue Jan 7, 2023 · 14 comments

Comments

@mrjbq7
Copy link
Contributor

mrjbq7 commented Jan 7, 2023 •
edited
Loading

I'm having an issue building a homebrew formula to package bzip3 for macOS due use of flat namespaces.

Here is the relevant discussion:

https://github.com/orgs/Homebrew/discussions/4091#discussioncomment-4621749

It appears we need to update autoconf to make a better configure script for macOS that does not pass $wl-flat_namespace. Some other formula maintain patches that update the configure scripts, for example:

https://raw.githubusercontent.com/Homebrew/formula-patches/03cf8088210822aa2c1ab544ed58ea04c897d9c4/libtool/configure-pre-0.4.2.418-big_sur.diff

It would be nicer if we can instead get an updated release with updated configure scripts, rather than maintaining a patch diff.

Also, is there a bzip3 website I should reference, or just this github project page.
@kspalaiologos
Copy link
Owner

Hi! I will look into updating autoconf. We are packaging bzip3 using ubuntu-latest, which is Ubuntu 22.04, which has autoconf 2.71, which is the most recent version to my knowledge. To which version should we update?

As for the website - sadly no, referencing this Github page should suffice. Thanks for putting in the effort to package bzip3 for Homebrew!

@mrjbq7
Copy link
Contributor Author

mrjbq7 commented Jan 7, 2023

That's a good question -- I see that autoconf 2.71 is the latest version, so perhaps Apple has a separate autoconf with patches. I will try and investigate that. Maybe a patch diff is what's required.

@kspalaiologos
Copy link
Owner

kspalaiologos commented Jan 7, 2023 •
edited
Loading

Interestingly, I use Debian Testing which supposedly uses the same version, but this piece of code linked in the patch is not present. The following is the comment header of generated configure on my machine:

#! /bin/sh
# Guess values for system-dependent variables and create Makefiles.
# Generated by GNU Autoconf 2.71 for bzip3 1.2.1.r5-g044136a.
#
# Report bugs to <https://github.com/kspalaiologos/bzip3>.
#
#
# Copyright (C) 1992-1996, 1998-2017, 2020-2021 Free Software Foundation,
# Inc.
#
#
# This configure script is free software; the Free Software Foundation
# gives unlimited permission to copy, distribute and modify it.

I have downloaded the tarball and the following is the comment header of the tarball:

#! /bin/sh
# Guess values for system-dependent variables and create Makefiles.
# Generated by GNU Autoconf 2.71 for bzip3 UNKNOWN.
#
# Report bugs to <https://github.com/kspalaiologos/bzip3>.
#
#
# Copyright (C) 1992-1996, 1998-2017, 2020-2021 Free Software Foundation,
# Inc.
#
#
# This configure script is free software; the Free Software Foundation
# gives unlimited permission to copy, distribute and modify it.

However, in the latter script, the patch can be applied.

@mrjbq7
Copy link
Contributor Author

mrjbq7 commented Jan 7, 2023

I've got a fix for it using a patch diff from the homebrew project, thank you!

@mrjbq7 mrjbq7 closed this as completed Jan 7, 2023
@mrjbq7 mrjbq7 mentioned this issue Jan 8, 2023
Closed
6 tasks
@mrjbq7 mrjbq7 reopened this Jan 8, 2023
@mrjbq7
Copy link
Contributor Author

mrjbq7 commented Jan 8, 2023

In working with homebrew to package bzip3 for all macOS users, they would like to have the configure script fixed upstream if at all possible. See this discussion:

Homebrew/homebrew-core#120028 (review)

I see a similar issue was opened and resolved on the ocaml project:

ocaml/ocaml#10723

They have their configure scripts committed to the repository to be able to take modifications. I suspect the autoconf on macOS has some patches from Apple that fix this versus the autoconf on ubuntu.

@kspalaiologos
Copy link
Owner

I am pretty certain that this issue is caused by an outdated version of libtool in Ubuntu repositories (check the build-aux/libtool.m4 file - it contains the patchable hunk)

@mrjbq7
Copy link
Contributor Author

mrjbq7 commented Jan 8, 2023

I updated the discussion on homebrew, it does appear that the current stable release of libtool 2.4.6 has the issue with newer macOS, but the development version of libtool has been fixed.

Homebrew/homebrew-core#120028 (comment)

The homebrew project seems to have a surprisingly high bar for new formula if they want to require upstream projects use a development version of libtool or somehow patch the current stable libtool.

What are your thoughts?

kspalaiologos added a commit that referenced this issue Jan 8, 2023
@kspalaiologos
bittersweet configure patch (to address #81)
e667cac
@mrjbq7
Copy link
Contributor Author

mrjbq7 commented Jan 8, 2023 •
edited
Loading

Note: if you used ubuntu 22.10 for making releases, (I know it's not LTS), this issue might be fixed as it uses libtool 2.4.7 which has a fix for it...

@kspalaiologos
Copy link
Owner

I can't use Ubuntu 22.10, because the Github Actions runners do not provide it.

@mrjbq7
Copy link
Contributor Author

mrjbq7 commented Jan 8, 2023

I appreciate your responsiveness here.

It does seems silly to upstream this patch when there is a perfectly good patching mechanism in homebrew for it, however I'm just trying to navigate their project to help macOS users use bzip3 more easily. Thank you!

@kspalaiologos
Copy link
Owner

kspalaiologos commented Jan 8, 2023 •
edited
Loading

It does seems silly to upstream this patch when there is a perfectly good patching mechanism in homebrew for it, however I'm just trying to navigate their project to help macOS users use bzip3 more easily. Thank you!

This is exactly how I feel about it. I have, all in all, decided to rollback the patch because it adds another layer of upstream maintainer effort and the hunk fails for some reason that I'm too tired to investigate now (I'll re-add it when I have enough time to do it properly)...

Please let the reviewers know that the issue will be fixed when there's libtool 2.4.7 in Ubuntu Jammy backports. In the meantime, I would recommend MacOS users to either use Nix (a better alternative to Homebrew) or MacPorts.

Thanks for putting in the effort!

PS: In the meantime, I've made sure to let the Ubuntu Jammy backports people know about this problem: https://bugs.launchpad.net/ubuntu/+source/libtool/+bug/2002251 - so a proper fix for this issue is presently pending another upstream (this time libtool and Ubuntu's) fix...

@chenrui333
Copy link

chenrui333 commented Jan 9, 2023 •
edited
Loading

It does seems silly to upstream this patch when there is a perfectly good patching mechanism in homebrew for it, however I'm just trying to navigate their project to help macOS users use bzip3 more easily. Thank you!

The main reason is to not duplicate the efforts if the project can incorporate the change, and underlying dependencies would also change over the time (so that patch also needs to be updated, see https://github.com/Homebrew/formula-patches/). I wont go too far on this as package manager maintainer.

Sometimes, homebrew formulae are also using macport patch, so I definitely think it is better to fix the cause rather than fixing the symptom.

@alerque
Copy link
Contributor

alerque commented Jan 9, 2023

Is there a libtool backport package for the LTS release we're building with now? This might be an easy fix.

Also have to confirmed that building source bundles with a newer libtool will fix this or are we still speculating?

@kspalaiologos
Copy link
Owner

kspalaiologos commented Jan 9, 2023 via email

kspalaiologos added a commit that referenced this issue Jan 10, 2023
@kspalaiologos @alerque
"fix" #81 (#84)
6359497 
* libtool patch

* keep the rest of the configure script as is

* missing newline

* update the location of the patch

* fail silently

* make the patching more.. transparent

* try an alternate way of solving this

* address the problems

* Change the mirror

Co-authored-by: Caleb Maclennan <caleb@alerque.com>

Co-authored-by: Caleb Maclennan <caleb@alerque.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mrjbq7 @alerque @chenrui333 @kspalaiologos