Readd fixed versions of unused pty regression tests #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/cmd/ksh93/tests/pty.sh: - Fix test for ksh93#722 by checking for 'Exit status 0' with 'u'. As far as I can tell this fixes the CI failure while still catching the crash on bugged commits. - Add a fixed version of the previously unused regression test from ksh93#356. Avoiding the CPU hungry lockup only requires spawning a child interactive shell for the crash to occur inside of. (This doesn't fix the underlying bug in pty, but merely works around it.)
McDutchie
pushed a commit
that referenced
this pull request
Mar 23, 2024
src/cmd/ksh93/tests/pty.sh: - Fix test for #722 by checking for 'Exit status 0' with 'u'. As far as I can tell this fixes the CI failure while still catching the crash on bugged commits. - Add a fixed version of the previously unused regression test from #356. Avoiding the CPU hungry lockup only requires spawning a child interactive shell for the crash to occur inside of. (This doesn't fix the underlying bug in pty, but merely works around it.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are fixed versions of two unused pty regression tests I intended to submit a week ago, but forgot about.
u. This should fix the CI failure while still catching the crash on bugged commits.pty, but merely works around it.)