Skip to content

Commit

Permalink
Remove _map_libc symbol (re: 4c39a97)
Browse files Browse the repository at this point in the history
It was only on by default for MVS (now z/OS, an IBM mainframe OS),
because apparently it doesn't allow overriding *any* libc functions
from shared libraries, so all AST functions had to be renamed. On
any system where we currently support shared libraries/dynamic
linking, this is not needed.

_map_libc could be optionally turned on by exporting
PACKAGE_OPTIONS=map-libc (that's what the features/options script
did) or by passing -D_map_libc in CCFLAGS. But I don't see any
actual use for this. Building with renaming all the functions was
broken for years and no one complained. I think we can do without
the maintenance load.
  • Loading branch information
McDutchie committed Aug 25, 2024
1 parent 4c39a97 commit b09d233
Show file tree
Hide file tree
Showing 5 changed files with 24 additions and 347 deletions.
1 change: 0 additions & 1 deletion src/cmd/ksh93/data/builtins.c
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@

#undef basename
#undef dirname
#undef mktemp /* undo possible map-libc mktemp => _ast_mktemp */

/*
* IMPORTANT: The order of these struct members must be synchronous
Expand Down
10 changes: 0 additions & 10 deletions src/lib/libast/Mamfile
Original file line number Diff line number Diff line change
Expand Up @@ -133,11 +133,6 @@ make install virtual
exec - invoke_iffe %{<}
done

make FEATURE/options
makp features/options
exec - invoke_iffe %{<}
done

note * sig.h: AST replacement for <signal.h>
make FEATURE/sig
makp features/sig.sh
Expand Down Expand Up @@ -186,11 +181,6 @@ make install virtual
make ast_map.h
make FEATURE/map
make features/map.c
prev sig.h
prev FEATURE/api
prev FEATURE/eaccess
prev FEATURE/options
prev FEATURE/mmap
prev FEATURE/lib
done
exec - invoke_iffe %{<} -I.
Expand Down
Loading

0 comments on commit b09d233

Please sign in to comment.