Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Golang to 1.21 #45

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Update Golang to 1.21 #45

merged 2 commits into from
Jun 27, 2024

Conversation

spolti
Copy link
Contributor

@spolti spolti commented Jun 19, 2024

No description provided.

Signed-off-by: Spolti <fspolti@redhat.com>
@ckadner ckadner self-requested a review June 26, 2024 20:23
Copy link
Member

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ckadner
Copy link
Member

ckadner commented Jun 26, 2024

/approve

1 similar comment
@ckadner
Copy link
Member

ckadner commented Jun 26, 2024

/approve

@oss-prow-bot oss-prow-bot bot removed the lgtm label Jun 26, 2024
Copy link
Member

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@oss-prow-bot oss-prow-bot bot added the lgtm label Jun 26, 2024
Copy link

oss-prow-bot bot commented Jun 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckadner, spolti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ckadner ckadner merged commit 32c7c01 into kserve:main Jun 27, 2024
6 checks passed
@spolti spolti deleted the go1.21 branch June 28, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants