Deduplicate the names for the additional domain names #3773
Conversation
Signed-off-by: Vincent Hou <shou73@bloomberg.net>
houshengbo
force-pushed
the
deduplicate-domain
branch
from
c255725
to
d72f764
Compare
Signed-off-by: Vincent Hou <shou73@bloomberg.net>
|
Could you fill in the all the sections in the PR description? like |
| "Failed to get the valid host name") | ||
| continue | ||
| // If the domain is redundant, go to the next element. | ||
| if !deduplicateMap[domain] { |
There was a problem hiding this comment.
just to confirm for boolean map this is good enough, we do not need to check the existence flag.
There was a problem hiding this comment.
Yes, this is good use of the boolean map.
If domain exists, the value is true; if it does not exist, the value is false.
| if stringMatchEqual(matchRequest.Authority, matchRequestEle.Authority) && gatewaysEqual(matchRequest, matchRequestEle) && | ||
| stringMatchEqual(matchRequest.Uri, matchRequestEle.Uri) { | ||
| return true | ||
| } |
There was a problem hiding this comment.
So we can't perform deepEqual directly on HTTPMatchRequest ?
There was a problem hiding this comment.
No, I tried. It seems I have to break them and check the field one by one with this approach.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: houshengbo, yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
configuration is invalid: duplicate hosts in virtual service. This PR removes the duplicated domain name for both additional domain names and domain names.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #3756
Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Test B
Logs
Special notes for your reviewer:
Checklist:
Release note:
Re-running failed tests
/rerun-all- rerun all failed workflows./rerun-workflow <workflow name>- rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.