Fix configmap docs removed by kustomize build #3024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sivanantha321
force-pushed
the
configmap-docs-fix
branch
3 times, most recently
from
cd98949 to
9e2a6a2
Compare
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
sivanantha321
force-pushed
the
configmap-docs-fix
branch
from
9e2a6a2 to
9b18bda
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sivanantha321, yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
yuzisun
added a commit
that referenced
this pull request
Aug 7, 2023
* Fix configmap docs removed by kustomize build (#3024) Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Loosen ray version range (#2993) * Loosen ray range Signed-off-by: ddelange <14880945+ddelange@users.noreply.github.com> * Fix import of RayServeHandle ref ray-project/ray#34714 Signed-off-by: ddelange <14880945+ddelange@users.noreply.github.com> * Allow pandas 2.0 Signed-off-by: ddelange <14880945+ddelange@users.noreply.github.com> * Remove exclusion markers Signed-off-by: ddelange <14880945+ddelange@users.noreply.github.com> * Run poetry lock --no-update Signed-off-by: ddelange <14880945+ddelange@users.noreply.github.com> --------- Signed-off-by: ddelange <14880945+ddelange@users.noreply.github.com> * Retry on resource conflict error (#3035) Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * chore: Fix `no space left on device` error in `predictor-runtime-build` (#3049) * Create a separate action to free-up disk space on GH action runner * Move 'free-up-disk-space' step outside 'minikube-setup' action * Free-up disk space before running 'predictor-runtime-build' Signed-off-by: Christian Kadner <ckadner@us.ibm.com> * Update MM version to v0.11.0-rc1 (#3047) Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com> * Bump scikit-learn version to 1.3.0 (#3040) * Bump scikit-learn version to 1.3.0 Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Update test models Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Downgrade ray serve to 2.4 Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> --------- Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * template out kube-rbac-proxy image (#3048) * template out kube-rbac-proxy image Signed-off-by: Tessa Pham <hpham111@bloomberg.net> * add kserve-addressable-resolver to clusterroles Signed-off-by: Tessa Pham <hpham111@bloomberg.net> --------- Signed-off-by: Tessa Pham <hpham111@bloomberg.net> * Add ARM64 arch support for serving runtimes (#3038) Except for Paddle, which does not support arm64/aarch64 Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Support secret name overrides with annotation (#3034) * Add annotation for secret name overrides Signed-off-by: Dan Sun <dsun20@bloomberg.net> * Remove the field Signed-off-by: Dan Sun <dsun20@bloomberg.net> * Fix secret name annotation Signed-off-by: Dan Sun <dsun20@bloomberg.net> * Update kserve url storage example docs Signed-off-by: Dan Sun <dsun20@bloomberg.net> * Address review comments Signed-off-by: Dan Sun <dsun20@bloomberg.net> * Update config docs for storage secret Signed-off-by: Dan Sun <dsun20@bloomberg.net> * Fix storage secret name Signed-off-by: Dan Sun <dsun20@bloomberg.net> * Add test for secret name annotation override Signed-off-by: Dan Sun <dsun20@bloomberg.net> * Fix flake8 lint Signed-off-by: Dan Sun <dsun20@bloomberg.net> --------- Signed-off-by: Dan Sun <dsun20@bloomberg.net> * release: Update defaultModelMeshVersion to v0.11.0 (#3059) Signed-off-by: Christian Kadner <ckadner@us.ibm.com> * chore: Rename ModelMesh validating webhook (#3064) Resolves #3063 Signed-off-by: Christian Kadner <ckadner@us.ibm.com> * Release v0.11.0 (#3061) Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Update poetry lock files (#3066) Signed-off-by: Dan Sun <dsun20@bloomberg.net> --------- Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> Signed-off-by: ddelange <14880945+ddelange@users.noreply.github.com> Signed-off-by: Christian Kadner <ckadner@us.ibm.com> Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com> Signed-off-by: Tessa Pham <hpham111@bloomberg.net> Signed-off-by: Dan Sun <dsun20@bloomberg.net> Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Co-authored-by: Sivanantham <90966311+sivanantha321@users.noreply.github.com> Co-authored-by: ddelange <14880945+ddelange@users.noreply.github.com> Co-authored-by: Christian Kadner <ckadner@us.ibm.com> Co-authored-by: Rafael Vasquez <raf.vasquez@ibm.com> Co-authored-by: Tessa Pham <hpham111@bloomberg.net> Co-authored-by: Andrews Arokiam <87992092+andyi2it@users.noreply.github.com>
Iamlovingit
pushed a commit
to Iamlovingit/kserve
that referenced
this pull request
Oct 1, 2023
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> Signed-off-by: iamlovingit <freecode666@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #3023
Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevent result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Test B
Logs
Special notes for your reviewer:
Checklist:
Release note: