Hotfix: A-record from bastion now pointing to public instead of priva…

…te IP (#9) * fixed documentation from deploy.sh to apply.sh * updated gitignore * added todos concerning disks * fixed bug: A-record from bastion now pointing to public instead of private IP * added todos
ksandermann · Jul 24, 2019 · 689eec2 · 689eec2
1 parent 46ab82b
commit 689eec2
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 4 deletions.
diff --git a/.gitignore b/.gitignore
@@ -5,4 +5,5 @@
 *.tfstate*
 *.log
 *.lock.info
-*/ssh_keys/*
+*/ssh_keys/*
+clusters/*
diff --git a/README.md b/README.md
@@ -51,7 +51,7 @@ It is basically the result of me teaching myself Terraform and Azure. :)
     export FORMKUBE_CLIENT_ID=abcde-abcde-abcde-abcde
     export FORMKUBE_CLIENT_SECRET=abcde-abcde-abcde-abcde
     export FORMKUBE_TENANT_ID=abcde-abcde-abcde-abcde
-    bash ./scripts/deploy.sh
+    bash ./scripts/apply.sh
     ```
 
 

diff --git a/docs/install_guide.md b/docs/install_guide.md
@@ -8,7 +8,7 @@
 
 1. Run the following inside bash in the repository's root directory:
     ```bash
-    ./scripts/deploy.sh
+    ./scripts/apply.sh
     ```
 
 # Authors

diff --git a/docs/todo.md b/docs/todo.md
@@ -11,6 +11,14 @@ always source this in apply.sh and
 source this in destroy.sh if plan file is not present.
 Need to be aware of development mode features
 
+* [ ] investigate on azure os disk size + filesystem size
+
+* [ ] azure disk encryption
+
+* [ ] don't destroy DNS zone
+
+* [ ] make cluster config path configurable
+
 # DONE 
 
 This list is just kept for development documentation purposes.

diff --git a/modules/azure/vnet/a-records.tf b/modules/azure/vnet/a-records.tf
@@ -4,7 +4,7 @@ resource "azurerm_dns_a_record" "bastions" {
   zone_name           = var.out_platform_dns_zone_name
   resource_group_name = var.out_platform_rg_name
   ttl                 = 300
-  records             = [azurerm_network_interface.bastions.*.ip_configuration.0.private_ip_address[count.index]]
+  records             = [azurerm_public_ip.bastions.*.ip_address[count.index]]
   tags                = var.platform_resource_tags
 
 }