Remove unnecessary memory alloc on rebalance when returing a tuple #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7 +/- ##
==========================================
+ Coverage 90.98% 91.05% +0.07%
==========================================
Files 4 4
Lines 255 257 +2
==========================================
+ Hits 232 234 +2
Misses 23 23
Continue to review full report at Codecov.
|
|
no difference in performance, not merging |
|
Reopening as it makes sense to have it done well, just need to improve the macro quality |
krynju
changed the title
krynju
force-pushed
the
fix_alloc_on_rebalance
branch
from
014d570
to
26fefe6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5 (comment)
Fixed, but needs better performance measurement.
Mem alloc is no longer there, but on the old benchmark there's no observable performance difference