This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
feat(initial): initial bare bones implementation #2
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
862b964
feat(initial): initial bare bones implementation
14fc680
style(initial): pr feedback
8b8ef8d
style(initial): return the class instead of instance as the export
c38e3a6
style(initial): renamed GoogleTag to GPT
24c69bb
test(unit): added initial real unit test suite
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
; This file is for unifying the coding style for different editors and IDEs. | ||
; More information at http://EditorConfig.org | ||
|
||
root = true | ||
|
||
[*] | ||
; Unix-style newlines with a newline ending every file | ||
end_of_line = lf | ||
insert_final_newline = true | ||
|
||
; tabs are evil | ||
indent_style = space | ||
indent_size = 2 | ||
|
||
; always UTF-8 | ||
charset = utf-8 | ||
|
||
trim_trailing_whitespace = true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
lib/** | ||
dist/** | ||
node_modules/** |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,233 @@ | ||
module.exports = { | ||
'parser': 'babel-eslint', | ||
'parserOptions': { | ||
'strict': 1, | ||
'ecmaVersion': 6, | ||
'sourceType': 'module' | ||
}, | ||
'env': { | ||
'browser': true, | ||
'commonjs': true, | ||
'es6': true | ||
}, | ||
'rules': { | ||
'comma-dangle': [ | ||
2, | ||
'never' | ||
], | ||
'no-cond-assign': [ | ||
2, | ||
'except-parens' | ||
], | ||
'no-console': 1, | ||
'no-constant-condition': 2, | ||
'no-control-regex': 2, | ||
'no-debugger': 1, | ||
'no-dupe-args': 2, | ||
'no-dupe-keys': 2, | ||
'no-duplicate-case': 2, | ||
'no-empty': 2, | ||
'no-empty-character-class': 2, | ||
'no-ex-assign': 2, | ||
'no-extra-boolean-cast': 2, | ||
'no-extra-semi': 2, | ||
'no-func-assign': 0, | ||
'no-inner-declarations': 0, | ||
'no-invalid-regexp': 2, | ||
'no-irregular-whitespace': 2, | ||
'no-negated-in-lhs': 2, | ||
'no-obj-calls': 2, | ||
'no-regex-spaces': 2, | ||
'quote-props': [ | ||
2, | ||
'as-needed', | ||
{ | ||
'keywords': true, | ||
'unnecessary': false | ||
} | ||
], | ||
'no-sparse-arrays': 0, | ||
'no-unreachable': 1, | ||
'use-isnan': 2, | ||
'valid-jsdoc': 0, | ||
'valid-typeof': 2, | ||
'block-scoped-var': 0, | ||
'complexity': 0, | ||
'consistent-return': 0, | ||
'curly': 2, | ||
'default-case': 1, | ||
'dot-notation': [ | ||
2, | ||
{ | ||
'allowKeywords': false | ||
} | ||
], | ||
'eqeqeq': 0, | ||
'guard-for-in': 1, | ||
'no-alert': 2, | ||
'no-caller': 2, | ||
'no-div-regex': 1, | ||
'no-else-return': 0, | ||
'no-eq-null': 0, | ||
'no-eval': 2, | ||
'no-extend-native': 2, | ||
'no-extra-bind': 2, | ||
'no-fallthrough': 2, | ||
'no-floating-decimal': 2, | ||
'no-implied-eval': 2, | ||
'no-iterator': 0, | ||
'no-labels': 2, | ||
'no-lone-blocks': 2, | ||
'no-loop-func': 2, | ||
'no-multi-spaces': 2, | ||
'no-multi-str': 1, | ||
'no-native-reassign': 2, | ||
'no-new': 2, | ||
'no-new-func': 2, | ||
'no-new-wrappers': 2, | ||
'no-octal': 2, | ||
'no-octal-escape': 2, | ||
'no-param-reassign': 0, | ||
'no-process-env': 2, | ||
'no-proto': 2, | ||
'no-redeclare': 2, | ||
'no-return-assign': 2, | ||
'no-script-url': 2, | ||
'no-self-compare': 2, | ||
'no-sequences': 2, | ||
'no-throw-literal': 2, | ||
'no-unused-expressions': 2, | ||
'no-void': 0, | ||
'no-warning-comments': 1, | ||
'no-with': 2, | ||
'radix': 2, | ||
'vars-on-top': 0, | ||
'wrap-iife': 2, | ||
'yoda': 0, | ||
'strict': 1, | ||
'no-catch-shadow': 2, | ||
'no-delete-var': 2, | ||
'no-label-var': 2, | ||
'no-shadow': 0, | ||
'no-shadow-restricted-names': 2, | ||
'no-undef': 2, | ||
'no-undef-init': 2, | ||
'no-undefined': 0, | ||
'no-unused-vars': [ | ||
2, | ||
{ | ||
'vars': 'all', | ||
'args': 'after-used' | ||
} | ||
], | ||
'no-use-before-define': [ | ||
2, | ||
'nofunc' | ||
], | ||
'no-mixed-requires': 0, | ||
'indent': 0, | ||
'brace-style': [ | ||
2, | ||
'1tbs', | ||
{ | ||
'allowSingleLine': true | ||
} | ||
], | ||
'camelcase': 2, | ||
'comma-spacing': [ | ||
2, | ||
{ | ||
'before': false, | ||
'after': true | ||
} | ||
], | ||
'comma-style': [ | ||
2, | ||
'last' | ||
], | ||
'consistent-this': [ | ||
1, | ||
'self' | ||
], | ||
'eol-last': 2, | ||
'func-names': 0, | ||
'func-style': [ | ||
2, | ||
'declaration' | ||
], | ||
'key-spacing': [ | ||
2, | ||
{ | ||
'beforeColon': false, | ||
'afterColon': true | ||
} | ||
], | ||
'max-nested-callbacks': 0, | ||
'new-cap': 2, | ||
'new-parens': 2, | ||
'newline-after-var': 0, | ||
'no-array-constructor': 2, | ||
'no-continue': 0, | ||
'no-inline-comments': 0, | ||
'no-lonely-if': 2, | ||
'no-mixed-spaces-and-tabs': 2, | ||
'no-multiple-empty-lines': 0, | ||
'no-nested-ternary': 1, | ||
'no-new-object': 2, | ||
'no-spaced-func': 2, | ||
'no-ternary': 0, | ||
'no-trailing-spaces': 2, | ||
'no-underscore-dangle': 0, | ||
'no-extra-parens': [ | ||
2, | ||
'functions' | ||
], | ||
'one-var': 0, | ||
'operator-assignment': 0, | ||
'padded-blocks': 0, | ||
'quotes': [ | ||
2, | ||
'single', | ||
'avoid-escape' | ||
], | ||
'semi': 2, | ||
'semi-spacing': [ | ||
2, | ||
{ | ||
'before': false, | ||
'after': true | ||
} | ||
], | ||
'sort-vars': 0, | ||
'keyword-spacing': 2, | ||
'space-before-blocks': [ | ||
2, | ||
'always' | ||
], | ||
'space-before-function-paren': [ | ||
2, | ||
{ | ||
'anonymous': 'never', | ||
'named': 'never' | ||
} | ||
], | ||
'space-in-brackets': 0, | ||
'space-in-parens': [ | ||
2, | ||
'never' | ||
], | ||
'space-infix-ops': 2, | ||
'space-unary-ops': 2, | ||
'spaced-comment': [ | ||
2, | ||
'always', | ||
{ | ||
'markers': [ | ||
',' | ||
] | ||
} | ||
], | ||
'wrap-regex': 1, | ||
'no-var': 1 | ||
} | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{ | ||
"preset": "google", | ||
"maximumLineLength": null, | ||
"validateQuoteMarks": { "mark": "'", "escape": true } | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
.codeclimate.yml | ||
.editorconfig | ||
.eslint* | ||
.idea/** | ||
.jscsrc | ||
.travis.yml | ||
CLA.md | ||
CONTRIBUTING.md | ||
gulpfile.babel.js | ||
src/** | ||
test/** | ||
webpack.config.babel.js | ||
*.iml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
/** | ||
* The command array accepts a sequence of functions and invokes them in order. | ||
* It is intended to replace a standard array that is used to enqueue functions | ||
* to be invoked once GPT is loaded. | ||
*/ | ||
export default class CommandArray { | ||
/** | ||
* Creates a new CommandArray. | ||
* | ||
* @param {Array<function()>} commands The commands to execute | ||
*/ | ||
constructor(commands) { | ||
this._count = 0; | ||
for (let f of commands) { | ||
this.push(f); | ||
} | ||
} | ||
|
||
/** | ||
* Executes the sequence of functions specified in the arguments in order. | ||
* | ||
* @param {function()} f A JavaScript function to be executed. | ||
* @returns {number} The number of commands processed so far. This is | ||
* compatible with Array.push's return value (the current length of the array). | ||
*/ | ||
push(f) { | ||
f(); | ||
this._count += 1; | ||
return this._count; | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean we don't use
"
s even if we've got to escape?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
per http://jscs.info/rule/validateQuoteMarks:
validateQuoteMarks
Requires all quote marks to be either the supplied value, or consistent if true
Types: Boolean, String or Object
Values: