feat(table): include returning subrows when on expandable multiple mode #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogermain-kronos
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
Storybook for this build: https://ds.equisoft.io/pr-1054/ |
ogermain-kronos
had a problem deploying
to
github-pages
GitHub Actions
Error
ogermain-kronos
temporarily deployed
to
github-pages
GitHub Actions
Inactive
ogermain-kronos
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
Webapp for this build: https://ds.equisoft.io/pr-1054/webapp/ |
savutsang
reviewed
Dec 10, 2024
pylafleur
reviewed
Dec 10, 2024
| const selectedRows = selectedIndexes.map((index: string) => { | ||
| if (rowSelectionMode === 'multiple') { | ||
| const [groupIndex, rowIndex] = index.split('.'); | ||
| return (data[parseInt(groupIndex, 10)] as T & { subRows?: Array<T> }) |
There was a problem hiding this comment.
Si on modifiait le type de la propriété data dans TableProps, on aurait plus besoin de l'assertion ici:
data: TableData<T>[];Tout passe encore, est-ce qu'il y aurait une contre-indication @savutsang?
There was a problem hiding this comment.
J'ai appliqué sa suggestion. Je vais regarder pour l'assertion ouère.
There was a problem hiding this comment.
Ça marche en castant le original du row en T.
There was a problem hiding this comment.
En fait data: T[] est plus exacte. T represente le type utilise par data.
ogermain-kronos
temporarily deployed
to
github-pages
GitHub Actions
Inactive
ogermain-kronos
temporarily deployed
to
github-pages
GitHub Actions
Inactive
savutsang
reviewed
Dec 10, 2024
ogermain-kronos
temporarily deployed
to
github-pages
GitHub Actions
Inactive
ogermain-kronos
temporarily deployed
to
github-pages
GitHub Actions
Inactive
savutsang
approved these changes
Dec 10, 2024
LarryMatte
pushed a commit
that referenced
this pull request
Jan 9, 2025
…de (#1054) * feat(table): include returning subrows when on expandable multiple mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://equisoft.atlassian.net/browse/DS-1279
La fonction
onSelectedRowsChangeretournait pas les subRows lorsque la data-table était configurée en mode multiple + expandable. Ça retournait juste des copies de la row parente du grouping.