feat: implement snark verifier poseidon #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chokobole
requested review from
batzor,
dongchangYoo,
TomTaehoonKim,
GideokKim and
ashjeong
chokobole
force-pushed
the
feat/implement-snark-verifier-poseidon
branch
3 times, most recently
from
39f43c8
to
e213dc4
Compare
GideokKim
reviewed
Jul 19, 2024
chokobole
force-pushed
the
feat/implement-snark-verifier-poseidon
branch
from
e213dc4
to
ed7af04
Compare
batzor
reviewed
Jul 19, 2024
chokobole
force-pushed
the
feat/implement-snark-verifier-poseidon
branch
2 times, most recently
from
f7360b2
to
5cc3896
Compare
GideokKim
reviewed
Jul 19, 2024
ashjeong
reviewed
Jul 19, 2024
chokobole
force-pushed
the
feat/implement-snark-verifier-poseidon
branch
from
5cc3896
to
cde51c3
Compare
This commit adds support for `SnarkVerifierPoseidonWriter`. Due to issues with adding the `snark-verifier-sdk` dependency, unit tests are excluded from this commit.
chokobole
force-pushed
the
feat/implement-snark-verifier-poseidon
branch
from
cde51c3
to
31e5f72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the efficient implementation of Poseidon as described in Supplementary Material B of the Poseidon paper and follows the implementation from scroll-tech/poseidon.