-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix grammatical errors #454
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! I gave a few comments, but besides that looks good~
solved the comments |
@cratiu222 Sorry for the late reply. Please follow the commit convention |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but let's fix the commit messages before merging
what needs to be fixed? |
We require relatively strict conventions for the users of the code. Additionally, the last two commits should be squashed into one since they modify the same file with the same content. |
@chokobole @dongchangYoo I think we can squash merge this? If not let's close this PR as stale. |
Close this PR, since it hasn't been updated so long. |
This PR corrects several grammatical errors in the documentation and comments, improving readability and clarity. These changes enhance the overall quality of the project’s written content.
Hope it helps.