fix(trie): dont save root hash twice #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyc228
force-pushed
the
fix/do-not-save-roothash-twice
branch
from
83ca498
to
66aace1
Compare
Pangssu
approved these changes
Jan 17, 2024
jyc228
force-pushed
the
fix/do-not-save-roothash-twice
branch
from
66aace1
to
77a3b33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, there was a bug that prevented the chain from running because the genesis block was not found after the ethereum/go-ethereum#26703 commit. It was solved by reversing the root hash when committing and saving it once more, but this resulted in using about 90 bytes of disk space per block and slowed down the block generation speed by about 30ms. (About 60ms -> 90m for 1 tx block, see related commit 6f7eadc )
This commit fixes the above.