Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem in comment regex match #758

Open
oradwell opened this issue Oct 2, 2015 · 1 comment
Open

Problem in comment regex match #758

oradwell opened this issue Oct 2, 2015 · 1 comment
Labels
defect

Comments

@oradwell
Copy link

oradwell commented Oct 2, 2015 

@import "sprites/*.png";

/* some comment */
.this-class {
    background-color: #666;
}

Assetic\Util\CssUtils::filterCommentless() returns:

@import "sprites
.this-class {
    background-color: #666;
}

Assetic\Util\CssUtils::filterCommentless() should ignore comment start (/*) if it is inside a string
@stof stof added the defect label Oct 2, 2015
AlexAsh added a commit to AlexAsh/assetic that referenced this issue Oct 6, 2015
@AlexAsh
Failing test for CssUtils::filterCommentless bug refs kriswallsmith#758
4574167
AlexAsh added a commit to AlexAsh/assetic that referenced this issue Oct 6, 2015
@AlexAsh
State class for state-based text analyzer refs kriswallsmith#758
6c60fe7
AlexAsh added a commit to AlexAsh/assetic that referenced this issue Oct 6, 2015
@AlexAsh
Tests for AnalyzerState class refs kriswallsmith#758
d923732
AlexAsh added a commit to AlexAsh/assetic that referenced this issue Oct 6, 2015
@AlexAsh
State-based CSS analyzer refs kriswallsmith#758
dc36f40
AlexAsh added a commit to AlexAsh/assetic that referenced this issue Oct 6, 2015
@AlexAsh
Tests for CssAnalyzer class refs kriswallsmith#758
bf3f31d
AlexAsh added a commit to AlexAsh/assetic that referenced this issue Oct 6, 2015
@AlexAsh
Implement correct comment filtering for CSS refs kriswallsmith#758
db13f9c
AlexAsh added a commit to AlexAsh/assetic that referenced this issue Oct 6, 2015
@AlexAsh
Changed LessUtils::filterCommentless base test to correspond CssUtils…
49579ea 
…::filterCommentless test refs kriswallsmith#758
AlexAsh added a commit to AlexAsh/assetic that referenced this issue Oct 6, 2015
@AlexAsh
Changed failing test LessUtilsTest::testFilterCommentlessLess to be m…
7f7dc72 
…ore catchall refs kriswallsmith#758
AlexAsh added a commit to AlexAsh/assetic that referenced this issue Oct 6, 2015
@AlexAsh
State-based LESS analyzer refs kriswallsmith#758
4d1dba4
AlexAsh added a commit to AlexAsh/assetic that referenced this issue Oct 6, 2015
@AlexAsh
Implement correct comment filtering for LESS refs kriswallsmith#758
14f3ad9
@AlexAsh AlexAsh mentioned this issue Oct 6, 2015
Open
AlexAsh added a commit to AlexAsh/assetic that referenced this issue Nov 5, 2015
@AlexAsh
Failing test for CssUtils::filterCommentless bug refs kriswallsmith#758
e497767
AlexAsh added a commit to AlexAsh/assetic that referenced this issue Nov 5, 2015
@AlexAsh
State class for state-based text analyzer refs kriswallsmith#758
4a2ef83
AlexAsh added a commit to AlexAsh/assetic that referenced this issue Nov 5, 2015
@AlexAsh
Tests for AnalyzerState class refs kriswallsmith#758
560882e
AlexAsh added a commit to AlexAsh/assetic that referenced this issue Nov 5, 2015
@AlexAsh
State-based CSS analyzer refs kriswallsmith#758
405e80e
AlexAsh added a commit to AlexAsh/assetic that referenced this issue Nov 5, 2015
@AlexAsh
Tests for CssAnalyzer class refs kriswallsmith#758
a5627b0
AlexAsh added a commit to AlexAsh/assetic that referenced this issue Nov 5, 2015
@AlexAsh
Implement correct comment filtering for CSS refs kriswallsmith#758
efb9d01
AlexAsh added a commit to AlexAsh/assetic that referenced this issue Nov 5, 2015
@AlexAsh
Changed LessUtils::filterCommentless base test to correspond CssUtils…
32701af 
…::filterCommentless test refs kriswallsmith#758
AlexAsh added a commit to AlexAsh/assetic that referenced this issue Nov 5, 2015
@AlexAsh
Changed failing test LessUtilsTest::testFilterCommentlessLess to be m…
f8fce9e 
…ore catchall refs kriswallsmith#758
AlexAsh added a commit to AlexAsh/assetic that referenced this issue Nov 5, 2015
@AlexAsh
State-based LESS analyzer refs kriswallsmith#758
fd271d4
AlexAsh added a commit to AlexAsh/assetic that referenced this issue Nov 5, 2015
@AlexAsh
Implement correct comment filtering for LESS refs kriswallsmith#758
78a871b
@andrewtch andrewtch mentioned this issue Jan 13, 2016
Merged
dhopkalo pushed a commit to tonicforhealth/assetic that referenced this issue Jan 13, 2016
kriswallsmith#758 - fix Problem in comment regex match
05201be
dhopkalo pushed a commit to tonicforhealth/assetic that referenced this issue Jan 13, 2016
kriswallsmith#758 - add single quote
4907d8f
@dhopkalo
Copy link

Original regex:
https://regex101.com/r/wV0aB8/6

Fixed:
https://regex101.com/r/yU7rT3/5

pls review

@dhopkalo dhopkalo mentioned this issue Jan 13, 2016
Open
dhopkalo pushed a commit to tonicforhealth/assetic that referenced this issue Jan 14, 2016
kriswallsmith#758 - update regex
8bfb8ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stof @oradwell @dhopkalo