Issue 105 #107
Merged
Issue 105 #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kris Nóva <kris@nivenly.com>
Signed-off-by: Kris Nóva <kris@nivenly.com>
Signed-off-by: Kris Nóva <kris@nivenly.com>
larsks
reviewed
Nov 24, 2021
| if len(cbytes) > 0 { | ||
| // We have both | ||
| fmt.Println(string(cbytes)) | ||
| fmt.Fprintf(os.Stderr, "\nWARNING ⚠\n\nUnable to parse full system: %v\n\nWARNING ⚠\n", err.Error()) |
There was a problem hiding this comment.
I thought this should go here so the error message can be explicit about the Kind that couldn't be converted. That sort of specificity in error messages is helpful (and maybe also in the default stanza -- or maybe just drop the *apiextensionsv1.CustomResourceDefinition stanza and rely on default -- for the same reasons you brought up in #105).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing concerns in 105
closes #105