Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade bullet to 2.82 #57

Closed
wants to merge 6 commits into from
Closed

Upgrade bullet to 2.82 #57

wants to merge 6 commits into from

Conversation

jazzzz
Copy link
Contributor

@jazzzz jazzzz commented Mar 5, 2014

I upgraded bullet to 2.82. The benchmark works, the tests pass except for one:
in 2.js, this assertion fails:

rayCallback.set_m_collisionObject(Ammo.wrapPointer(195));
assertEq(typeof rayCallback.get_m_collisionObject(), 'object');

rayCallback.get_m_collisionObject() returns the number 195 instead of the wrapped pointer, do you have an idea why?

@jazzzz
Copy link
Contributor Author

jazzzz commented Mar 5, 2014

All CubicVR.js samples also pass.

@kripken
Copy link
Owner

kripken commented Mar 5, 2014

My current hope is to in the near future get to writing the new bindings code for emscripten, then rewrite the relevant parts here to use that. I suppose it would be also a good time to update to very latest bullet. It should make figuring out what is going wrong in that test much easier. For that reason, perhaps lets wait on the bullet upgrade until then.

@jazzzz
Copy link
Contributor Author

jazzzz commented Mar 6, 2014

OK, let's wait. For now, this build works well enough for me to use it instead of bullet 2.78, as I needed some new features like the rolling friction.

@kripken
Copy link
Owner

kripken commented Mar 6, 2014

Cool, thanks for contributing this.

On Thu, Mar 6, 2014 at 2:26 AM, Jazz notifications@github.com wrote:

OK, let's wait. For now, this build works well enough for me to use it
instead of bullet 2.78, as I needed some new features like the rolling
friction.

Reply to this email directly or view it on GitHubhttps://github.com//pull/57#issuecomment-36842436
.

@kripken
Copy link
Owner

kripken commented Apr 24, 2014

There is an update to bullet 2.82 in the webidl branch, see issue #60, so we can close this. If you have time to help there that would be great.

@kripken kripken closed this Apr 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants