New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use forwardRef to pass on the ref(#169) #182

Merged

koistya merged 2 commits into kriasoft:main from chinmaychaudhary:master

Jul 22, 2021

Contributor

chinmaychaudhary commented Apr 7, 2020 •

edited

Loading

For a Component that is wrapped with withStyles, attaching ref on it doesn't attach the ref on the Component.

Using forwardRef to fix this.

Problems it could cause:

clashing names - if someone is passing a prop with the name __$$withStylesRef, it will be NOT be sent to ComposedComponent

chinmaychaudhary force-pushed the master branch 8 times, most recently from c7b9401 to 19d4c32 Compare

April 8, 2020 06:15


          Use forwardRef to pass on the ref(kriasoft#169)

2e892fe

chinmaychaudhary force-pushed the master branch from 19d4c32 to 2e892fe Compare

April 8, 2020 06:19


          Merge branch 'main' into master

6c0dac5

koistya merged commit 24964b4 into kriasoft:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet