Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tenant Awareness #79

Closed
wants to merge 1 commit into from
Closed

Tenant Awareness #79

wants to merge 1 commit into from

Conversation

sl0wik
Copy link
Contributor

@sl0wik sl0wik commented Feb 2, 2021

@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #79 (0344ae2) into main (4fa91e5) will decrease coverage by 0.77%.
The diff coverage is 50.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##                main      #79      +/-   ##
=============================================
- Coverage     100.00%   99.22%   -0.78%     
- Complexity        46       47       +1     
=============================================
  Files              3        3              
  Lines            127      129       +2     
=============================================
+ Hits             127      128       +1     
- Misses             0        1       +1     
Impacted Files Coverage Δ Complexity Δ
src/FirebaseProjectManager.php 98.24% <50.00%> (-1.76%) 25.00 <0.00> (+1.00) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fa91e5...c6ad3a1. Read the comment docs.

@jeromegamez
Copy link
Member

Nice and short, thank you very much! 🌺

Merged with c2f9569 and released as https://github.com/kreait/laravel-firebase/releases/tag/3.1.0 🚀

I renamed authentication to auth because the SDK also refers to it as the "Auth" component, updated FIREBASE_TENANT_ID to FIREBASE_AUTH_TENANT_ID (to keep the FIREBASE_<COMPONENT>_<NAME> scheme), and added a test, all in your name, I hope that's okay 😅

@jeromegamez jeromegamez closed this Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants