Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Jest, remove tests, uninstall related packages #53

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

krau5
Copy link
Owner

@krau5 krau5 commented Nov 21, 2024

I have decided to remove Jest and all the existing tests. This decision stems from how the Pomo app was built. The Pomo timer should function properly even when the user switches tabs or minimizes the browser, so it relies on web workers. Unfortunately, this creates challenges for testing, as mocking the worker becomes necessary.

In my opinion, adding tests that rely on mocking the core functionality undermines their purpose. They become tests added for the sake of having tests, rather than meaningful validations of the application and its flow.

I have not yet found a way to test the application in the way I want. Therefore, I believe it is better to remove the current tests for now and reintroduce them when I can implement legitimate and meaningful testing.

@krau5
Copy link
Owner Author

krau5 commented Nov 21, 2024

image

@krau5 krau5 merged commit 2e632a1 into main Nov 21, 2024
1 check passed
@krau5 krau5 deleted the chore-refactor branch November 21, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant