Implement notched box plots, closes #2286 #1
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,287 @@ | ||
| { | ||
| "data":[ | ||
|
There was a problem hiding this comment. Very nice test images! re: the labels getting cut off - that'll get fixed by plotly#2243 but here we might as well just give it a larger left margin so they fit. |
||
| { | ||
| "x":[ | ||
| 90, | ||
| 88, | ||
| 55, | ||
| 88, | ||
| 72, | ||
| 100, | ||
| 88, | ||
| 25, | ||
| 92, | ||
| 100, | ||
| 82, | ||
| 82, | ||
| 90, | ||
| 68, | ||
| 85, | ||
| 82, | ||
| 40, | ||
| 100, | ||
| 92, | ||
| 82, | ||
| 55, | ||
| 62, | ||
| 85, | ||
| 100, | ||
| 75, | ||
| 88, | ||
| 78, | ||
| 80, | ||
| 92, | ||
| 100, | ||
| 88, | ||
| 72, | ||
| 95, | ||
| 80, | ||
| 90, | ||
| 72, | ||
| 100, | ||
| 100, | ||
| 75, | ||
| 82, | ||
| 60, | ||
| 90, | ||
| 85, | ||
| 90, | ||
| 38, | ||
| 78, | ||
| 82, | ||
| 100, | ||
| 90, | ||
| 80, | ||
| 80, | ||
| 100, | ||
| 70, | ||
| 100, | ||
| 82, | ||
| 62, | ||
| 92, | ||
| 100, | ||
| 80, | ||
| 100, | ||
| 88, | ||
| 85 | ||
| ], | ||
| "line":{ | ||
| "color":"#1c9099" | ||
| }, | ||
| "type":"box", | ||
| "name":"Notched = True", | ||
| "orientation": "h", | ||
| "notched":true | ||
| }, | ||
| { | ||
| "x":[ | ||
| 70, | ||
| 65, | ||
| 85, | ||
| 75, | ||
| 72, | ||
| 75, | ||
| 90, | ||
| 88, | ||
| 85, | ||
| 80, | ||
| 92, | ||
| 85, | ||
| 85, | ||
| 75, | ||
| 72, | ||
| 80, | ||
| 42, | ||
| 80, | ||
| 95, | ||
| 90, | ||
| 62, | ||
| 65, | ||
| 65, | ||
| 82, | ||
| 68, | ||
| 48, | ||
| 57, | ||
| 95, | ||
| 70, | ||
| 100, | ||
| 80, | ||
| 95, | ||
| 78, | ||
| 80, | ||
| 80, | ||
| 85, | ||
| 90, | ||
| 100, | ||
| 52, | ||
| 85, | ||
| 72, | ||
| 70, | ||
| 45, | ||
| 75, | ||
| 85, | ||
| 95, | ||
| 65, | ||
| 70, | ||
| 85, | ||
| 70, | ||
| 85, | ||
| 35, | ||
| 90, | ||
| 95, | ||
| 95, | ||
| 65, | ||
| 62, | ||
| 48, | ||
| 60, | ||
| 85, | ||
| 85, | ||
| 90, | ||
| 70, | ||
| 68 | ||
| ], | ||
| "line":{ | ||
| "color":"#1c9099" | ||
| }, | ||
| "type":"box", | ||
| "name":"Notch width = 0.8", | ||
| "notched":true, | ||
| "orientation": "h", | ||
| "notchwidth":0.8 | ||
| }, | ||
| { | ||
| "x":[ | ||
| 95, | ||
| 75, | ||
| 70, | ||
| 72, | ||
| 52, | ||
| 70, | ||
| 82, | ||
| 90, | ||
| 95, | ||
| 80, | ||
| 68, | ||
| 88, | ||
| 82, | ||
| 52, | ||
| 80, | ||
| 78, | ||
| 57, | ||
| 88, | ||
| 88, | ||
| 100, | ||
| 50, | ||
| 65, | ||
| 78, | ||
| 92, | ||
| 65, | ||
| 50, | ||
| 60, | ||
| 88, | ||
| 100, | ||
| 50, | ||
| 90, | ||
| 70, | ||
| 60, | ||
| 72, | ||
| 75, | ||
| 95, | ||
| 100, | ||
| 45, | ||
| 68, | ||
| 72, | ||
| 45, | ||
| 60, | ||
| 78, | ||
| 85, | ||
| 92, | ||
| 45, | ||
| 68, | ||
| 70, | ||
| 85, | ||
| 82, | ||
| 62, | ||
| 75, | ||
| 100, | ||
| 80, | ||
| 65, | ||
| 52, | ||
| 48, | ||
| 57, | ||
| 100, | ||
| 72, | ||
| 100, | ||
| 80, | ||
| 65 | ||
| ], | ||
| "line":{ | ||
| "color":"#1c9099" | ||
| }, | ||
| "type":"box", | ||
| "name":"Notch width = 1", | ||
| "notched":true, | ||
| "orientation": "h", | ||
| "notchwidth":1 | ||
| }, | ||
| { | ||
| "x":[ | ||
| 86, | ||
| 64, | ||
| 86.2, | ||
| 91.1, | ||
| 86, | ||
| 85.3, | ||
| 85.30000000000001, | ||
| 63.7, | ||
| 47.400000000000006, | ||
| 89.2, | ||
| 91.3, | ||
| 91.6, | ||
| 55.099999999999994, | ||
| 64.1, | ||
| 76.2, | ||
| 91.4, | ||
| 68.9, | ||
| 60.8, | ||
| 64.5, | ||
| 87.7, | ||
| 21, | ||
| 97.6, | ||
| 90.9, | ||
| 86.6, | ||
| 100, | ||
| 33.6, | ||
| 82.7, | ||
| 63.599999999999994, | ||
| 55.5, | ||
| 80.7, | ||
| 85, | ||
| 92.30000000000001, | ||
| 48.9, | ||
| 85 | ||
| ], | ||
| "line":{ | ||
| "color":"#1c9099" | ||
| }, | ||
| "type":"box", | ||
| "name":"Outside of hinges", | ||
| "orientation": "h", | ||
| "notched":true | ||
| } | ||
| ], | ||
| "layout":{ | ||
| "showlegend":false, | ||
| "xaxis":{ | ||
| "title":"Grade [%]", | ||
| "type":"linear" | ||
| }, | ||
| "title":"Based on Fig 4.4a: Course Grade Distributions", | ||
| "yaxis":{ | ||
| "type":"category" | ||
| }, | ||
| "height":598, | ||
| "width":1080, | ||
| "autosize":true | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like Matlab and ggplot have opposite conventions about this... if I'm reading it right this is the ggplot version. I would have probably gone for the Matlab version, where
notchwidth=0is nothing taken away, andnotchwidth=0.5is notches that meet in the middle (actually I might have called that1instead... but we don't want to introduce yet ANOTHER convention). I guess I don't have that strong an opinion about it though, @etpinard or @cpsievert do you care which we use?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point; I will wait for others to express their opinion. Just to have it here: the behavior (and description) of
notchwidthis based on another, already existing attribute -whiskerwidth.