Re-focus input after modifying model, keep input for 0.5s #77

krassowski · 2023-12-01T13:14:00Z

References

Fixes https://github.com/jupyterlab/jupyterlab/issues/ 12322

Code changes

immediately after submission the input box will reject inputs (but not disabled to keep focus)
a green ✓tick will show next to the input box in 0.1s after submission
the input box will fade away in 0.4s
the input box will be detached after 0.5s

TODO:

add a test case
maybe add a config option?

User-facing changes

users will receive a subtle visual indication confirming their input was sent (previously this was impossible to distinguish for sending an empty reply)
users will be able to quickly send replies without the input box loosing focus and leading to the code editor being overwritten

Backwards-incompatible changes

None

Tested that it fails on main reproducing the issue: ``` - Expected - 0 + Received + 8 from time import sleep input() print('before sleep') sleep(0.1) print('after sleep') + + + x + + + + + ```

https://bugzilla.mozilla.org/show_bug.cgi?id=1867893 `:has()` is not only not yet officially supported but is hard to implement well so no wonder there are difficult invalidation bugs

Re-focus input after modifying model, keep input for 0.5s

77476a7

github-actions bot added Design System CSS tag:CSS pkg:outputarea labels Dec 1, 2023

krassowski added the bug Something isn't working label Dec 1, 2023

Add a test case against the focus loss issue

e2d1d7b

Tested that it fails on main reproducing the issue: ``` - Expected - 0 + Received + 8 from time import sleep input() print('before sleep') sleep(0.1) print('after sleep') + + + x + + + + + ```

github-actions bot added the tag:Testing label Dec 1, 2023

krassowski added 3 commits December 2, 2023 13:03

Give up on using animations and :has() solution due to FF bug

51d9f9d

https://bugzilla.mozilla.org/show_bug.cgi?id=1867893 `:has()` is not only not yet officially supported but is hard to implement well so no wonder there are difficult invalidation bugs

More robust stdin test

c8a0336

Merge branch 'main' into workaround/input-box-focus

3aa773f

krassowski closed this Mar 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Re-focus input after modifying model, keep input for 0.5s #77

Re-focus input after modifying model, keep input for 0.5s #77

krassowski commented Dec 1, 2023 •

edited

Loading

Re-focus input after modifying model, keep input for 0.5s #77

Re-focus input after modifying model, keep input for 0.5s #77

Conversation

krassowski commented Dec 1, 2023 • edited Loading

References

Code changes

User-facing changes

Backwards-incompatible changes

krassowski commented Dec 1, 2023 •

edited

Loading