forked from jupyterlab/jupyterlab
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring jupyterlab-recents into the core #76
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Design System CSS
tag:CSS
pkg:docmanager
pkg:filebrowser
pkg:mainmenu
labels
Nov 30, 2023
krassowski
force-pushed
the
feature/recents-manager
branch
from
November 30, 2023 14:37
424cc23
to
f5bca42
Compare
krassowski
commented
Nov 30, 2023
@@ -121,7 +121,17 @@ export namespace IFileBrowserFactory { | |||
/** | |||
* The token that indicates the default file browser commands are loaded. | |||
*/ | |||
export const IFileBrowserCommands = new Token<void>( | |||
export const IFileBrowserCommands = new Token<IFileBrowserCommands>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO should it be?
Suggested change
export const IFileBrowserCommands = new Token<IFileBrowserCommands>( | |
export const IFileBrowserCommands = new Token<IFileBrowserCommands | void>( |
krassowski
force-pushed
the
feature/recents-manager
branch
from
November 30, 2023 15:48
f5bca42
to
fc7b98f
Compare
krassowski
force-pushed
the
feature/recents-manager
branch
from
December 4, 2023 00:19
094dba8
to
d5d0fbf
Compare
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com> Co-authored-by: Shreyas Cholia <shreyas@gmail.com> Co-authored-by: Matt Henderson <mhenderson@lbl.gov> Co-authored-by: Trevor Slaton <trevor.slaton@gmail.com> Co-authored-by: Adrien Delsalle <ad.delsalle@gmail.com>
The cycle was introduced by removing void on returned Promise. Because void operator returns undefined, the promise on `IFileBrowserCommands` was never awaited (on main branch) which meant that `@jupyterlab/filebrowser-extension:widget` (the only dependant of commands token) was able to initialise as soon as the commands were activated (not waiting for the reveal/settings promises cascade); this commits restores ignoring the result of the promise and instead returns the command mapping after the promise was invoked.
Move type to `Private`, add docstrings Automatic application of license header
krassowski
force-pushed
the
feature/recents-manager
branch
from
December 4, 2023 00:22
d5d0fbf
to
5a76d51
Compare
krassowski
force-pushed
the
feature/recents-manager
branch
from
December 4, 2023 00:55
5a76d51
to
a668bb3
Compare
github-actions
bot
added
documentation
Improvements or additions to documentation
pkg:notebook
tag:Testing
pkg:apputils
pkg:completer
pkg:ui-components
labels
Jan 15, 2024
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
by removing protected method used in only one place
* Fix manager isDisposed is not set * Check the current code is buggy * Re apply the fix and lint * Lint the code
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
* Re-organise the kernel tree in sidebar * Implement list view and toggle, improve buttons state * Slightly reduce size of collapse/expand icons * Also open menu over widget entries (children of kernels) this makes the menu accessible in the list view * Implement toggle memory for list/view switch * Fix button state initialization * Simplify state setup for buttons * Integrity lint * Update selectors in tests * Fix selector in test * Fix buttons behaviour when resizing down * Add a timeout in test, update one snapshot * Use icons from ToC, make kernel ID grey * Make it only one collapse/expand button * Update snapshots * Freeze kernel IDs for snapshots * Update snapshots * Fix tooltip label
…erlab into feature/recents-manager
krassowski
force-pushed
the
feature/recents-manager
branch
from
March 21, 2024 11:10
ab321d7
to
8854035
Compare
Before this commit we had two very similar snapshots: - interface-tabs-documentation-linux.png - running-layout-documentation-linux.png both showing "open tabs" and "kernels" sections. After this commit the former now only shows "open tabs" reducing the burden reviewing snapshots when kernels are flaky or when kernels section changes
krassowski
force-pushed
the
feature/recents-manager
branch
from
March 21, 2024 11:12
8854035
to
0bcc5f5
Compare
and the final nth no longer matches after closing nth-1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Design System CSS
documentation
Improvements or additions to documentation
feature
pkg:application
pkg:apputils
pkg:attachments
pkg:cell-toolbar
pkg:cells
pkg:celltags
pkg:codeeditor
pkg:codemirror
pkg:completer
pkg:console
pkg:coreutils
pkg:csvviewer
pkg:debugger
pkg:docmanager
pkg:docregistry
pkg:documentsearch
pkg:extensionmanager
pkg:filebrowser
pkg:fileeditor
pkg:help
pkg:htmlviewer
pkg:hub
pkg:imageviewer
pkg:inspector
pkg:javascript
pkg:json
pkg:launcher
pkg:logconsole
pkg:lsp
pkg:mainmenu
pkg:markdownviewer
pkg:mathjax
pkg:mermaid
pkg:metadataform
pkg:notebook
pkg:observables
pkg:outputarea
pkg:pdf
pkg:pluginmanager
pkg:property-inspector
pkg:rendermime
pkg:running
pkg:services
pkg:settingeditor
pkg:settingregistry
pkg:shortcuts
pkg:statedb
pkg:statusbar
pkg:terminal
pkg:themes
pkg:toc
pkg:tooltip
pkg:translation
pkg:ui-components
pkg:vega
tag:CSS
tag:Examples
tag:Testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
TODO:
recentlyClosed
Code changes
Compared to
jupyterlab-recents
extension:IFileBrowserCommands
to explicitly depend on the availability of the filebrowser to open directories (and to fallback to document manager command if filebrowser does not provide such tokenBecause rather than adding a new package the extension gets integrated on the lower level by adding separate plugins to relevant existing packages (document manager, main menu) merging git history did no make much sense; instead the autorship was preserved by using
Co-authored-by
feature.User-facing changes
Open Recent submenu
Recently closed in the sidebar
Reopen modal
Backwards-incompatible changes
None.