Define cells to run independent of selection #65
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krassowski
changed the title
github-actions
bot
added
documentation
github-actions
bot
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Addresses # 13361
Instead of relying on selection state for running cells (which is how individual run commands are implemented), save the cells to run before asynchronous actions to ensure that selection changes do not influence which cells get run.
Code changes
Private.runSelected()functionNotebookActions.runCells()functionnotebook:restart-and-run-to-selectedandnotebook:restart-run-allcommands to useNotebookActions.runCellsUser-facing changes
When restarting and re-running up to selected cell, the cell which was selected during invoking the command (rather than the cell selected after restart) will be the one executed in the end.
Backwards-incompatible changes
None I think.