Build updates: Python 3, ppc64le alias, publish checksums #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Time to do this — Python 2 is EOL. This exposed a bug in one of the tests that was stripping the entire environment from its subprocesses (though they did sort of work on Python 2).
This isn't being used at all.
Fixes #152. This doesn't hurt, and we already do it for e.g. unsuffixed and amd64. We're pretty close to a more distinguished mechanism for aliases being worth it, though.
Fixes #153. It doesn't hurt to have those, though in general clients probably shouldn't rely too much on getting their binary and their checksum from the same source.
|
@krallin Thanks for the PR and being flexible about adding the SHAs! |
This was referenced Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.