Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the build of bpftrace ptest failed #972

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

hongxu-jia
Copy link
Contributor

@hongxu-jia hongxu-jia commented Jul 8, 2024

…t failed

Due to commit [1][2], llvm-native was added to bpftrace to provide llvm-objcopy for the ptest.

But because of commit [3], llvm-native requires opengl in DISTRO_FEATURES to support libllvm.

In order to make the build of bpftrace ptest work, explicitly add libllvm to PACKAGECONFIG for llvm-native if ptest enabled.

According to [2][3], bpftrace used llvm-objcopy to generate BTF data for unit tests, regardless opengl in DISTRO_FEATURES, enable accelerated software renderer or not does not have side effect on bpftrace

[1] bf6c02a
[2] bpftrace/bpftrace@6cc531e
[3] https://git.openembedded.org/openembedded-core/commit/?id=ec22bfa67f6f1766102501d4593ce29aafe8c166


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

…t failed

Due to commit [1][2], llvm-native was added to bpftrace to provide llvm-objcopy
for the ptest.

But because of commit [3], llvm-native requires opengl in DISTRO_FEATURES
to support libllvm.

In order to make the build of bpftrace ptest work, explicitly add libllvm to
PACKAGECONFIG for llvm-native if ptest enabled.

According to [2][3], bpftrace used llvm-objcopy to generate BTF data for unit tests,
regardless opengl in DISTRO_FEATURES, enable accelerated software renderer or not
does not have side effect on bpftrace

[1] kraj@bf6c02a
[2] bpftrace/bpftrace@6cc531e
[3] https://git.openembedded.org/openembedded-core/commit/?id=ec22bfa67f6f1766102501d4593ce29aafe8c166

Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
@hongxu-jia hongxu-jia requested a review from kraj as a code owner July 8, 2024 09:04
Copy link
Owner

@kraj kraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kraj kraj merged commit 0c2b19b into kraj:master Jul 9, 2024
1 check passed
@kraj
Copy link
Owner

kraj commented Jul 10, 2024

I had to revert this due to it causing check-layer to fail. meta-clang is yocto-compatible certified and we can not break that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants