Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use common interface in joiners and loaders #235

Merged

Conversation

piotrgramacki
Copy link
Collaborator

Closes #230

@piotrgramacki piotrgramacki requested a review from Calychas April 24, 2023 18:08
@piotrgramacki piotrgramacki self-assigned this Apr 24, 2023
@piotrgramacki piotrgramacki linked an issue Apr 24, 2023 that may be closed by this pull request
@Calychas Calychas force-pushed the 230-unify-interfaces-of-base-classes-with-the-descendants branch from 9428eb5 to b49b512 Compare April 24, 2023 19:09
@Calychas Calychas force-pushed the 230-unify-interfaces-of-base-classes-with-the-descendants branch from b49b512 to 8d2f202 Compare April 24, 2023 21:10
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #235 (2a44b61) into main (fa5c79a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #235   +/-   ##
=======================================
  Coverage   97.78%   97.79%           
=======================================
  Files          52       52           
  Lines        1491     1495    +4     
=======================================
+ Hits         1458     1462    +4     
  Misses         33       33           
Flag Coverage Δ
macos-latest-python3.10 ?
ubuntu-latest-python3.10 97.79% <100.00%> (+0.07%) ⬆️
ubuntu-latest-python3.8 97.71% <100.00%> (+<0.01%) ⬆️
ubuntu-latest-python3.9 97.71% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
srai/joiners/_base.py 100.00% <ø> (ø)
srai/joiners/intersection_joiner.py 100.00% <100.00%> (ø)
srai/loaders/_base.py 100.00% <100.00%> (ø)
srai/loaders/geoparquet_loader.py 100.00% <100.00%> (ø)
srai/loaders/gtfs_loader.py 100.00% <100.00%> (ø)
srai/loaders/osm_loaders/_base.py 97.77% <100.00%> (+0.05%) ⬆️
srai/loaders/osm_loaders/osm_online_loader.py 100.00% <100.00%> (ø)
srai/loaders/osm_loaders/osm_pbf_loader.py 92.50% <100.00%> (ø)
srai/loaders/osm_way_loader/osm_way_loader.py 98.12% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Calychas Calychas added the Skip-Changelog Skip changelog enforcer label Apr 24, 2023
srai/loaders/_base.py Show resolved Hide resolved
@piotrgramacki piotrgramacki merged commit 553179d into main Apr 25, 2023
@piotrgramacki piotrgramacki deleted the 230-unify-interfaces-of-base-classes-with-the-descendants branch April 25, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip-Changelog Skip changelog enforcer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify interfaces of base classes with the descendants
2 participants