Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add contextual count embedder #220

Merged
merged 33 commits into from
Apr 25, 2023
Merged

Conversation

RaczeQ
Copy link
Collaborator

@RaczeQ RaczeQ commented Apr 13, 2023

No description provided.

@RaczeQ RaczeQ added the enhancement New feature or request label Apr 13, 2023
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #220 (996b866) into main (b6b0342) will increase coverage by 3.17%.
The diff coverage is 98.82%.

@@            Coverage Diff             @@
##             main     #220      +/-   ##
==========================================
+ Coverage   94.61%   97.78%   +3.17%     
==========================================
  Files          47       52       +5     
  Lines        1392     1489      +97     
==========================================
+ Hits         1317     1456     +139     
+ Misses         75       33      -42     
Flag Coverage Δ
macos-latest-python3.10 97.78% <98.82%> (+3.31%) ⬆️
ubuntu-latest-python3.10 97.71% <98.82%> (+3.17%) ⬆️
ubuntu-latest-python3.8 97.71% <98.82%> (+3.18%) ⬆️
ubuntu-latest-python3.9 97.77% <98.82%> (+3.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
srai/embedders/gtfs2vec/embedder.py 100.00% <ø> (ø)
srai/embedders/gtfs2vec/model.py 100.00% <ø> (ø)
srai/embedders/highway2vec/embedder.py 100.00% <ø> (ø)
srai/embedders/highway2vec/model.py 100.00% <ø> (ø)
srai/joiners/intersection_joiner.py 100.00% <ø> (ø)
srai/loaders/gtfs_loader.py 100.00% <ø> (ø)
srai/loaders/osm_way_loader/constants.py 100.00% <ø> (ø)
srai/loaders/osm_way_loader/osm_way_loader.py 98.11% <ø> (ø)
srai/loaders/osm_loaders/filters/_typing.py 95.45% <95.45%> (ø)
srai/loaders/osm_loaders/_base.py 97.72% <97.72%> (ø)
... and 15 more

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

srai/embedders/__init__.py Outdated Show resolved Hide resolved
srai/embedders/contextual_count_embedder.py Outdated Show resolved Hide resolved
@RaczeQ RaczeQ marked this pull request as ready for review April 19, 2023 18:25
piotrgramacki
piotrgramacki previously approved these changes Apr 23, 2023
Calychas
Calychas previously approved these changes Apr 24, 2023
@RaczeQ RaczeQ dismissed stale reviews from Calychas and piotrgramacki via d3edb79 April 24, 2023 20:37
@RaczeQ RaczeQ merged commit cd3d479 into main Apr 25, 2023
@RaczeQ RaczeQ deleted the add-contextual-count-embedder branch April 25, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants