Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CountEmbedder and OSMTagLoader examples, handle osmnx as optional in OSMTagLoader #185

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

simonusher
Copy link
Collaborator

No description provided.

…ore: utilize other library parts in CountEmbedder example, chore: simplify OSMTagLoader example, fix: wrong print in OSMTagLoader example
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #185 (ba4a393) into main (39b75e3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #185   +/-   ##
=======================================
  Coverage   99.30%   99.31%           
=======================================
  Files          30       30           
  Lines         724      727    +3     
=======================================
+ Hits          719      722    +3     
  Misses          5        5           
Flag Coverage Δ
macos-latest-python3.10 99.03% <100.00%> (+<0.01%) ⬆️
ubuntu-latest-python3.10 99.03% <100.00%> (+0.14%) ⬆️
ubuntu-latest-python3.8 99.17% <100.00%> (+0.28%) ⬆️
ubuntu-latest-python3.9 98.89% <100.00%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
srai/loaders/osm_tag_loader/osm_tag_loader.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@simonusher simonusher merged commit 350b843 into main Feb 23, 2023
@simonusher simonusher deleted the 138-improve-count-embedder-example-notebook branch February 23, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants