Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add index name to regionizers #182

Merged

Conversation

piotrgramacki
Copy link
Collaborator

Closes #181

@piotrgramacki piotrgramacki self-assigned this Feb 22, 2023
@piotrgramacki piotrgramacki linked an issue Feb 22, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #182 (358424a) into main (ee45614) will decrease coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #182      +/-   ##
==========================================
- Coverage   99.30%   99.16%   -0.14%     
==========================================
  Files          30       30              
  Lines         715      720       +5     
==========================================
+ Hits          710      714       +4     
- Misses          5        6       +1     
Flag Coverage Δ
ubuntu-latest-python3.10 98.88% <100.00%> (-0.42%) ⬇️
ubuntu-latest-python3.8 98.88% <100.00%> (+<0.01%) ⬆️
ubuntu-latest-python3.9 99.16% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
srai/joiners/intersection_joiner.py 100.00% <100.00%> (ø)
.../regionizers/administrative_boundary_regionizer.py 95.14% <100.00%> (ø)
srai/regionizers/h3_regionizer.py 100.00% <100.00%> (ø)
srai/regionizers/s2_regionizer.py 100.00% <100.00%> (ø)
srai/regionizers/voronoi_regionizer.py 100.00% <100.00%> (ø)
srai/utils/constants.py 100.00% <100.00%> (ø)
srai/regionizers/_spherical_voronoi.py 99.14% <0.00%> (-0.86%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@piotrgramacki piotrgramacki merged commit a82bc96 into main Feb 22, 2023
@piotrgramacki piotrgramacki deleted the 181-regionizers-should-return-result-with-named-index branch February 22, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regionizers should return result with named index
2 participants