translation: Update classification_of_data_structure.md #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refined some parts here and there. Overall its pretty accurate anyways. Merry Christmas everyone!
K3v123
changed the title
krahets
reviewed
Dec 27, 2023
krahets
reviewed
Dec 27, 2023
docs-en/chapter_data_structure/classification_of_data_structure.md
Outdated
Show resolved
Hide resolved
krahets
reviewed
Dec 27, 2023
docs-en/chapter_data_structure/classification_of_data_structure.md
Outdated
Show resolved
Hide resolved
krahets
reviewed
Dec 27, 2023
krahets
reviewed
Dec 27, 2023
docs-en/chapter_data_structure/classification_of_data_structure.md
Outdated
Show resolved
Hide resolved
krahets
reviewed
Dec 27, 2023
docs-en/chapter_data_structure/classification_of_data_structure.md
Outdated
Show resolved
Hide resolved
|
Hi @K3v123 , do you use WeChat? If so, please add me |
I tried to fix most of the stuff listed, um some the empty spaces looks different from the editor view, so its a bit hard to see, not sure if i did it correct or not. thanks again for the review Krahets
yuelinxin
reviewed
Dec 29, 2023
There was a problem hiding this comment.
Thank you for your contribution, please address the comments. Also, you can use the changed line counter on GitHub to make sure that you didn't add or remove any line accidentally, theoretically, the number of added and removed lines should be the same.
For example, it could be "+8 -8".
docs-en/chapter_data_structure/classification_of_data_structure.md
Outdated
Show resolved
Hide resolved
docs-en/chapter_data_structure/classification_of_data_structure.md
Outdated
Show resolved
Hide resolved
docs-en/chapter_data_structure/classification_of_data_structure.md
Outdated
Show resolved
Hide resolved
docs-en/chapter_data_structure/classification_of_data_structure.md
Outdated
Show resolved
Hide resolved
Made changes to to what Yuelinxin and Krahets pointed out. Deleted extra lines. again thanks and sorry for my inadvertence.
Phoenix0415
reviewed
Dec 30, 2023
docs-en/chapter_data_structure/classification_of_data_structure.md
Outdated
Show resolved
Hide resolved
docs-en/chapter_data_structure/classification_of_data_structure.md
Outdated
Show resolved
Hide resolved
docs-en/chapter_data_structure/classification_of_data_structure.md
Outdated
Show resolved
Hide resolved
re-edited, with changes that Phoenix0415 has mentioned. thank you so much for the review Phoenix!
After having another skim through, I realized that I have misunderstood, what Phoenix is saying, so I recap'd the bold ones again. sorry for the inconvenience
Phoenix0415
approved these changes
Dec 30, 2023
3 tasks
krahets
approved these changes
Jan 1, 2024
There was a problem hiding this comment.
Thanks for the PR and the review from @yuelinxin @Phoenix0415 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refined some parts here and there.
Overall its pretty accurate anyways.
Merry Christmas everyone!
If this PR is related to coding or code translation, please fill out the checklist and paste the console outputs to the PR.