Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes "TypeError: 'NoneType' object is not iterable" mentioned in #1959 (comment).
This error happens because
Watcher._run
expects theWatch
callable object returns an iterable:python-etcd3/etcd3/watch.py
Lines 128 to 136 in e78000e
but
slow_watch_mock
, which is used intest_watch_timeout_on_establishment
returns nothing:python-etcd3/tests/test_etcd3.py
Lines 379 to 382 in e78000e
This PR modifies
slow_watch_mock
to return an empty list to avoid the type error.Also, it updates
Dockerfile
to use Python 3.9 and newer etcd.