Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

139 meteorologicalaphrodite daily mean temp #150

Open
wants to merge 129 commits into
base: main
Choose a base branch
from
Open

139 meteorologicalaphrodite daily mean temp #150

wants to merge 129 commits into from

Conversation

rowannicholls
Copy link
Collaborator

@rowannicholls rowannicholls commented Jan 8, 2025 •
edited
Loading

Order in which to review and merge:

rowannicholls and others added 30 commits February 12, 2024 22:59
@rowannicholls
Edits to fix linting
f19faaa
@rowannicholls
Re-structured code into functions
3687355
@rowannicholls
Added tests for the new functions (16 tests in total)
af093c3
@rowannicholls
Merge remote-tracking branch 'origin/main' into 30-re-structure-the-c…
797436a 
…ode-such-that-each-metric-download-is-in-its-own-function
@rowannicholls
Implemented new method of parsing credentials and new functionality o…
b76fd3e 
…f specifying path of credentials file
@rowannicholls
Re-ran tests in different folder
d3ef414
@rowannicholls
WIP: re-structuring the B script
2b295a0
@rowannicholls
WIP
3ef4103
@rowannicholls
WIP
ffa137c
@rowannicholls
Finished processing CHIRPS data
4f822d1
@rowannicholls
Finished processing all data
e47a025
@rowannicholls
Re-structured the B script
dc28069
@rowannicholls
Minor changes
d9ac1ed
@rowannicholls
Updated tests
fd3ccdd
@rowannicholls
All except 7 tests (in test_process_data.py) have been implemented
3fd3f87
@rowannicholls
Finished testing the processing of meteorological data
0ec154a
@rowannicholls
Added test_process_geospatial_meteorological_data() and test_process_…
ff1ff22 
…gadm_chirps_data()
@rowannicholls
Added tests for the processing of geospatial and sociodemographic data
8993ea8
@rowannicholls
Merge branch '30-re-structure-the-code-such-that-each-metric-download…
5b1e7e7 
…-is-in-its-own-function' into 47-process-terraclimate-data
@rowannicholls
Re-ran on macOS
a109d8a
@rowannicholls
Merge remote-tracking branch 'origin/main' into 47-process-terraclima…
0a0504e 
…te-data
@rowannicholls
Finished writing and testing
ba93aad
@rowannicholls
Update .gitignore
168e748
@rowannicholls
Suggested changes and formatting
1847b01 
Changes suggested by AD from code review plus some formatting changes
@rowannicholls
All get functions working except dengue/peru
3bc417f
@rowannicholls
WIP
6bea639
@rowannicholls
Updated gitignore
109dd2e
@rowannicholls
Aggregating RWI by region and updating existing data if it exists
937706f
@rowannicholls
Fixed RWI aggregation and updating
c8ff56d
@rowannicholls
Merge branch '120-aggregate-relative-wealth-index-data-by-region' int…
7e8d823 
…o 119-confirm-existing-metrics-run-through-the-re-factored-pipeline
@rowannicholls
Merge remote-tracking branch 'origin/135-meteorologicalaphrodite-dail…
8501158 
…y-precip' into 139-meteorologicalaphrodite-daily-mean-temp
@rowannicholls
Merge remote-tracking branch 'origin/main' into 130-epidemiologicalde…
1676907 
…ngueperu
@rowannicholls
Merge remote-tracking branch 'origin/130-epidemiologicaldengueperu' i…
f89543f 
…nto 135-meteorologicalaphrodite-daily-precip
@rowannicholls
Merge branch '135-meteorologicalaphrodite-daily-precip' into 139-mete…
d1961ac 
…orologicalaphrodite-daily-mean-temp
@rowannicholls
Addressing comments
aecd5f4
@rowannicholls
Merge branch '130-epidemiologicaldengueperu' into 135-meteorologicala…
fd40323 
…phrodite-daily-precip
@rowannicholls
Merge branch '135-meteorologicalaphrodite-daily-precip' into 139-mete…
8cd8e47 
…orologicalaphrodite-daily-mean-temp
@rowannicholls
Merge remote-tracking branch 'origin/main' into 135-meteorologicalaph…
fd169a4 
…rodite-daily-precip
@rowannicholls
Merge branch '135-meteorologicalaphrodite-daily-precip' into 139-mete…
a2c4a93 
…orologicalaphrodite-daily-mean-temp
@rowannicholls
Linting errors
88999b5
@rowannicholls
Linting errors
bfa553b
@rowannicholls
Linting errors
6fa23df
@rowannicholls
Removed temperature functions
039612d
@rowannicholls
Removed temperature functions
abee2a6
@rowannicholls
Linting errors
7831ec2
@rowannicholls
Added temperature back in
faad50c
@rowannicholls rowannicholls linked an issue Jan 8, 2025 that may be closed by this pull request
meteorological/aphrodite-daily-mean-temp #139
Open
@rowannicholls rowannicholls mentioned this pull request Jan 8, 2025
Open
@rowannicholls rowannicholls requested a review from abhidg January 8, 2025 10:29
This was referenced Jan 8, 2025
Open
Open
Open
Open
@abhidg
Copy link
Contributor

abhidg commented Jan 8, 2025 •
edited
Loading

This appears to be essentially the same as #149?

@rowannicholls
Copy link
Collaborator Author

This appears to be essentially the same as #149?

Temperature as opposed to precipitation. But the changes in #149 have been merged in

@abhidg
Copy link
Contributor

abhidg commented Jan 27, 2025

@rowannicholls APHRODITE will not be in the MVP, so feel free to close this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhidg abhidg Awaiting requested review from abhidg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

meteorological/aphrodite-daily-mean-temp
2 participants
@rowannicholls @abhidg