Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Order of Start Errors #22

Open
koya0 opened this issue Jan 17, 2025 · 22 comments
Open

Wrong Order of Start Errors #22

koya0 opened this issue Jan 17, 2025 · 22 comments

Comments

@koya0
Copy link
Owner

koya0 commented Jan 17, 2025

When user comments /start, at least the first error should say that there is no price label so this can't be started.

@koya0
Copy link
Owner Author

koya0 commented Jan 17, 2025

We are having problems with the order of errors of start command. The first error displayed is "This task does not reflect a business priority at the moment...", but should be "No price label is set to calculate the duration". 1

Footnotes

  1. 87% similar to issue: Wrong Order of Start Errors

@koya0
Copy link
Owner Author

koya0 commented Jan 17, 2025

/annotate

@0x4007
Copy link

0x4007 commented Jan 17, 2025

Curious to know how much information you seeded your database with before we are testing this

@koya0
Copy link
Owner Author

koya0 commented Jan 18, 2025

Curious to know how much information you seeded your database with before we are testing this

actually only this issue is on database, lol.

@0x4007
Copy link

0x4007 commented Jan 18, 2025

@shiv810 I think we need to either open source our production database or you should provide instructions for your scraper.

Otherwise we can't really QA this stuff

@0x4007
Copy link

0x4007 commented Jan 18, 2025

One time we we working on a fix where the price label should be the first thing that start command checks for and throws an error for 1

Footnotes

  1. 88% similar to issue: Wrong Order of Start Errors

@0x4007
Copy link

0x4007 commented Jan 18, 2025

/annotate

@shiv810
Copy link

shiv810 commented Jan 18, 2025

@shiv810 I think we need to either open source our production database or you should provide instructions for your scraper.

Its open source Scraper, should I move this to ubiquity org instead ?

@0x4007
Copy link

0x4007 commented Jan 18, 2025

I suppose it would make sense to transfer it to @ubiquity-os and also make a note of it in the vector embeddings readme.

@koya0
Copy link
Owner Author

koya0 commented Jan 18, 2025

We are having problems with the order of errors of start command. The first error displayed is "This task does not reflect a business priority at the moment...", but should be "No price label is set to calculate the duration". 1

Footnotes

  1. 87% similar to issue: Wrong Order of Start Errors

@koya0
Copy link
Owner Author

koya0 commented Jan 18, 2025

/annotate #22 (comment) global

@0x4007
Copy link

0x4007 commented Feb 5, 2025

/help

@0x4007
Copy link

0x4007 commented Feb 5, 2025

@0x4007
Copy link

0x4007 commented Feb 5, 2025

/annotate ubiquity-os/plugins-wishlist#66 (comment) global

@koya0
Copy link
Owner Author

koya0 commented Feb 5, 2025

Sorry, my kernel is off, I will turn it on

@0x4007
Copy link

0x4007 commented Feb 5, 2025

That was a test to see if it would have permissions problems on other repositories, organizations, and such. It should due to different JWT based on the GitHub app installation ID

@0x4007
Copy link

0x4007 commented Feb 5, 2025

/annotate ubiquity-os/plugins-wishlist#66 (comment) global

Copy link

bot-koya bot commented Feb 5, 2025

! Not Found - https://docs.github.com/rest/issues/comments#get-an-issue-comment

@0x4007
Copy link

0x4007 commented Feb 5, 2025

But either way I can't seem to get the plugin to work. Can you fix?

@0x4007
Copy link

0x4007 commented Feb 5, 2025

! Not Found - https://docs.github.com/rest/issues/comments#get-an-issue-comment

I suppose we eventually should throw a specific and clear error saying that this is out of the current organization and it does not have permissions to annotate it.

@koya0
Copy link
Owner Author

koya0 commented Feb 5, 2025

! Not Found - https://docs.github.com/rest/issues/comments#get-an-issue-comment

I suppose we eventually should throw a specific and clear error saying that this is out of the current organization and it does not have permissions to annotate it.

I think the problem here is that the the bot only gets the comment id of the link, and supposes that the comment is from the same org and repo from the annotate command, so if you try to annotate a command from another repo, it will break

https://github.com/ubiquity-os-marketplace/text-vector-embeddings/blob/0f9188453aed5c8816509ab5a438fbba80205ed1/src/handlers/annotate.ts#L25-L29

@koya0
Copy link
Owner Author

koya0 commented Feb 5, 2025

I didnt get the org and repo from the url cause I thought this wouldnt be necessary, it doesnt make much sense the user wanting to annotate a comment from another issue in the issue that his making comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants